2013/6/15 Piotr Przybylski piotr.prz@gmail.com:
2013/6/15 Rouslan Placella rouslan@placella.com
On 06/14/2013 09:01 PM, Mohamed Ashraf wrote:
On Friday, June 14, 2013 at 9:10 PM, Rouslan Placella wrote:
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I read the files in the setup directory however I am not sure how to add my setting to the setup script. there seems to be some way the forms are automatically generated however I do not seem to be able to reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably don't need to understand how the setup scripts work that much.
The procedure that I would take would be:
- Find a configuration variable that exists in the setup, but not in
the user preferences. Let's take $cfg['RecodingEngine']
- grep for it (eg: git grep RecodingEngine)
- Look in all files whose names sound like they have something to do
with the configuration.
- See where the RecodingEngine variable appears in these files
- Copy + paste + edit
- Check if it works
Hope this helps.
Thanks I had already figuered it out. However I am not sure about the difference between the settings in user preferences which use the cookie as storage and the config.inc.php ones since they are both in the $cfg variable. If they share a single variable name who gets preference.
User preferences are saved to localStorage or PMA configuration storage, no cookies involved. And AFAIK user preferences can override config.inc.php.
Bye, Rouslan
User preferences are stored in PMA configuration storage or in user session (then they are lost when session expires). They can be backed up and restored from localStorage.
All options available in setup script are defined in setup.forms.php, and all options that can be changed by users are stored in user_preferences.forms.php (unless an option is excluded by UserprefsDisallow array - then users can't change it).
Thanks for clarifying this, Piotr. Something like this should be on the wiki. Any volunteers to add it?
-- Kind regards,
Dieter Adriaenssens