Hello Marc,

`Parser::$STATEMENT_PARSERS` is a constant (its value remains the same during run-time), but I could not declare it as I should because it is illegal to declare constant arrays in versions prior to PHP 5.6. Also, I decided to avoid the `const` keyword in integer or string constants for consistency reasons. Do you think that I should rename the constant arrays and add the `const` keyword to other declarations?

On Mon, Jun 8, 2015 at 3:14 PM, Marc Delisle <marc@infomarc.info> wrote:

Hi Dan,

At this point, since you prefer to work in your own repository [0], I
cannot add line comments via Github so I'll send my comments to this list.

Please explain why in [1] you are using uppercase. This should be only
for constants.

[0] https://github.com/udan11/sql-parser

[1] https://github.com/udan11/sql-parser/blob/master/src/Parser.php#L19

--
Marc Delisle | phpMyAdmin

------------------------------------------------------------------------------
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel