On Sun, Jul 8, 2012 at 6:28 PM, Chanaka Dharmarathna < pe.chanaka.ck@gmail.com> wrote:
Hi Marc,
Hi,
can someone explain the goal of this method? AFAIK it's never called.
I introduce this method inside PMA_DisplayResults class. As you mentioned, this method has used nowhere. I thought that this will useful for further improvements as well
generally
getter setter methods use inside classes. But not sure it will definitely use in future.
It can be removed since it is not using at the moment. What should be better ?
Regards !
Chanaka, I'm not sure, let's see opinions of others on this.
I think, as to set the local PMA_CommonFunctions object of any class
using setCommonFunctions(), we would always need the existing single object using PMA_CommonFunctions::getInstance(). And when we use local getCommonFunctions(), it already sets the local PMA_CommonFunctions object to PMA_CommonFunctions::getInstance(). So I see no particular utility of setCommonFunctions().
Hi Marc,
I introduce common setter method for set any property of that class. So I'll remove setCommonFunctions() function since the expected behavior can obtain from the common setter.
Regards !
Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel