On Tue, May 31, 2011 at 10:51 AM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Tue, 31 May 2011 10:43:01 +0200 Tyron Madlener tyronx@gmail.com napsal(a):
One more patch suggestion:
- Commit 9385012b97b4c188618ee8658d4e7a3b9200aa5d
The status page displays percentual and averaged numbers, which for very low values displays 0.0% or 0.0 which is mathematically seen incorrect. The supplied patch changes such values into "<0.1", or verbally expressed: "Smaller than the smallest value I can display". It's calculated with "(1/PMA_pow(10,$comma))", so its always the smallest displayable value.
Makes sense. But please for next time keep formatting changes in separate commit, to ease bug finding in future (you can use some graphical tool or git add -i to choose which hunks you want to be part of the commit).
Alright, will do. (it was done more or less automatically by my text editor)
Er, actually not, because you should display 0 when then value is 0 and not <1 in such case.
You mean for values without comma? Are there cases where such behavior is required in pma?
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel