I have a better approach, We'll count the no of characters before an ajax load, and on event request count again and compare.
But should this cause selenium test to fail? is there any test case which should trigger the dialog where it is expected to trigger?  


Minhaz
cistoner.org


On Wed, Apr 23, 2014 at 7:17 PM, Michal Čihař <michal@cihar.com> wrote:
Hi

Dne Tue, 22 Apr 2014 17:16:35 +0530
Minhaz A V <minhazav@gmail.com> napsal(a):

> I was thinking this code could be modified to check if any input field was
> changed from the value it was loaded with if some user try to perform ajax
> operation or any operation that triggers onbeforeunload event.

Looks like a better approach. On page/ajax load the initial value would
be stored in some data attribute and the trigger would then check it
for change. Though there might be some javascript generated values not
covered by this...

> AJAX code will go well in ajax.js while for onbeforeunload section, I'd add
> an event listener to it in common.js as mentioned by Atul.
>
> If you guys feel this feature should not exist in pma, I'd stop here on
> this. Kindly let me know by night or I'll start writing :D, as I feel this
> feature should be there.

This is indeed useful feature, but it should not block normal usage as
the first implementation did.

> Also, is it possible to add a branch for this in pma, till this feature is
> working well or I should come up with a whole working one in my fork before
> I pull.

You can have branch in your fork, no need to add branch to upstream
repository.

--
        Michal Čihař | http://cihar.com | http://blog.cihar.com

------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel