On Thu, Jul 21, 2011 at 2:40 PM, Thilanka Kaushalya
<lgtkaushalya(a)gmail.com> wrote:
Hi Marc,
1. please follow Rouslan's suggestions;
however, the variable, after the
split, really contains a span id (to find the other footnote span)
2. please add a comment just before the line containing the split,
explaining that this variable contains two classes at this point (for
example "footnotemarker footnote_1_1")
3. also add a comment, using for example footnote_2_3 and that after the
split, the variable contains 2, so will find the footnote #2
I did the above changes and pushed to the repo.
I find it a bit hazardous to use this split on a string which contains
two classes. You never know, another class having an underscore could be
added to this element in the future.
I change the logic a little, and in that case it is more safe with splitting
and getting the id.
Another thing I find unclear: in and
PMA_convertFootnotesToTooltips() you have kept the principle of using
the instance of the footnote, even though the goal of the instance was
only to have unique ids. IMO you should get rid of the instance.
I removed it and pushed my changes to the repo.
Now I find two new errors with this.One is an firebug error which says
w"http://localhost/phpmyadmin-gsoc/themes/pmahomme/img/ic_b_triggers 404
(Not Found)" when I click on "DB->Structure->insert". It appears in
non ajax
scenario also.
I probably caused that when Michal merged my repo to master. The
problem is in tbl_links.inc.php where 'ic_b_triggers' is assigned as
icon.
So to fix it either rename it to b_triggers.png or just wait for my
css sprites changes to be merged to master (assuming that it is going
to be merged)
The next one is when I go to "Sakila"
database and try to insert for
actor_info table it gives an error. But in ajax enabled dialog shows the
json string is not parsed clearly. I cannot parse the whole data content at
the "$("td.insert_table a.ajax").live('click')" action in
db_structure.js
file because the returned content from tbl_change.php file is not 100% an
json response. That ajax response was passed at the line 604 in
common.lib.php and it seems not parsing correctly. Can you please help me on
this issue. Thank you.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog :
http://coders-view.blogspot.com/
------------------------------------------------------------------------------
5 Ways to Improve & Secure Unified Communications
Unified Communications promises greater efficiencies for business. UC can
improve internal communications as well as offer faster, more efficient ways
to interact with customers and streamline customer service. Learn more!
http://www.accelacomm.com/jaw/sfnl/114/51426253/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel