On Sat, Jun 30, 2012 at 5:56 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-06-30 08:18, Thilina Buddika Abeyrathna a écrit :
On Sat, Jun 30, 2012 at 5:31 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2012-06-30 03:04, Thilina Buddika Abeyrathna a écrit :
Hi Marc, There are two hard coded values in server_privileges.lib.php script
which
username and hostname lengths. (line 849). Can we define those values
in
a
config file and access using $GLOBAL['cfg']['username_length'] and $GLOBAL['cfg']['hostname_length'], Then it'll maintainable.
Hi Thilina, I cannot find this in your repo, please reply by posting a code snippet.
in server_privileges.lib.php (lin 844) $username_length = 16; $hostname_length = 41; My suggestion was, remove the hard corded value and define those hard corded values in config file and access using $GLOBAL['cfg']['username_length'] etc.
Well, these values have been chosen by MySQL itself; I'm not sure what to do with them, as I don't see why a person installing phpMyAdmin would need to change them.
When we add configuration directives, we must have a clear reason.
Ok Marc, Thank you.