Hello,

Basically, that code is responsible for finding and removing aliases. The old code (that I replaced) is this [1]. As far as I understand (now), aliases should only be removed from the `FROM` clause and wherever they are found in other clauses.

I had a fix prepared, but exams and homework came and I did not get to work on it anymore. My last exam is on 16. If no other fix is proposed by then, I will push mine.

[1] https://github.com/phpmyadmin/phpmyadmin/blob/RELEASE_4_4_15/tbl_export.php#L39

On Sun, Dec 13, 2015 at 8:41 PM, Raghu Ram <raghuram.vadapalli@research.iiit.ac.in> wrote:

I think that part of code need not be removed. An empty array is passed for replaces where actually an array of tokens is expected (I am talking about call to replaceTokens function on https://github.com/phpmyadmin/phpmyadmin/blob/master/tbl_export.php#L109). That is the reason aliases are not replaced.

On Sun, Dec 13, 2015 at 11:37 PM, Marc Delisle <marc@infomarc.info> wrote:
Hi Dan,

in tbl_export.php you wrote some logic (lines 116 to 172) that deals
with aliases. Could you give a use case where this logic is important? I
am asking because of

https://github.com/phpmyadmin/phpmyadmin/issues/11679
and
https://github.com/phpmyadmin/phpmyadmin/pull/11738

--
Marc Delisle | phpMyAdmin

_______________________________________________
Developers mailing list
Developers@phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers

_______________________________________________
Developers mailing list
Developers@phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers