6 May
2011
6 May
'11
1:07 p.m.
Le 2011-05-06 05:20, Tyron Madlener a écrit :
On Fri, May 6, 2011 at 8:37 AM, Madhura Jayaratne
<madhura.cj(a)gmail.com> wrote:
I agree that we should tend to respect the standard more and I agree
with the exceptions given by Tyron.
About HTML output, let's be proactive into refactoring this whenever
possible.
--
Marc Delisle
http://infomarc.info
Hi all,
Although we have chosen PEAR coding standards[1] as the coding standard for
phpMyAdmin[2], there are quite a number of occasions where the standard is
being violated, especially the line length recommendation. For example in
display_tbl.lib.php I can see lines with 282 character while
the recommended limit is 75-85[3].
However, I feel that this limit is bit too restrictive given that some lines
have indentation of about 32 spaces. So I think it's better to set the limit
bit leniently (at least for those files) and adhering to it rather than
ignoring the line length limit altogether. Any thoughts?
With things clarified all the GSoCers would be able to produce quality code
during this summer.
Indentation probably doesn't count to the line length :)
Nonetheless, there's indeed many places in pma that violates this
guideline. I think it also depends on the type of code; as long as the
crucial parts are kept short, it should be fine. Things like html
output or language strings don't need to be short in order to be
readable, imo.