On Tue, Apr 10, 2012 at 4:56 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Mon, 9 Apr 2012 15:51:59 +0500 Adnan hiddenpearls@gmail.com napsal(a):
On Sat, Apr 7, 2012 at 2:02 PM, Adnan hiddenpearls@gmail.com wrote:
I wanted to discuss about the bad design patterns used in schema generation classes. According to my knowledge,
- In Class PMA_Schema_PDF and other schema classes, properties are
used
with var which is deprecated from PHP 5.0 to 5.1.3 as declaring
properties
like var was standard in php4. So, in php5 standards are to use public,protected or private keywords. Though after 5.1.3 var is not deprecated and doesn't issue E_STRICT warning. so var used in current
code
is considered as public. Best pattren is to use protected keyword for properties in Schema classes.
- Singleton/factory pattern is not used in schema classes. I guess,
we
should use it instead of instantiating objects on running scripts.
any input on this please ?
Yes, you have input at the proposal. Please try to avoid spreading same topic over several channels. Also do not expect everybody is online and has time 24/7 - people are away from computers sometimes.
Thanks for input. Sorry, It will never happen again.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel