On Mon, Aug 1, 2011 at 7:03 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Fri, 22 Jul 2011 22:34:55 +0530 Madhura Jayaratne madhura.cj@gmail.com napsal(a):
Looking at the CheckStyle reports from the CI, all the export files show very high counts of indentation rule violations. The code in the 'else' block of 'if (isset($plugin_list))' condition is wrongly indented in all of these files.
There are two possible ways to correct this.
- Correctly indent the 'else' block
- Add 'return' statement to the end of 'if' block and remove 'else {'
part.
Which one if preferred?
I don't think 2 will work, so out of these 1 is only solution. Rewrite it so that same functions are not defined in all plugins (using classes instead) would be preferable solution, though it is much more complex than reindenting :-).
Yep, I was comparing it with the import plugins and didn't notice that these contains methods. So what is preferred, reindenting as a quick solution or letting it there as it is till it is rewritten in OOP?