Yes, I will do my detailed discussion there.
I've already commented on this in the issue tracker: Not sure how to best approach this, but we should avoid the double encoding problem. On the other side the charset selector for import has to stay for SQL files which do not do SET NAMES and for other formats like CSV. Maybe disable our charset conversion once we spot SET NAMES in the SQL? If you want to followup, please do that in the issue tracker, so that whole discussion stays in one place.
Manish Bisht Email : hi@manishbisht.me Website : https://manishbisht.me
On Wed, Mar 1, 2017 at 4:35 PM, Manish Bisht manish.bisht490@gmail.com wrote:
Any update on my implementation of this ?
- Improve responsive/mobile interface
Is there any designed proposed for mobile till now ? The last discussion i can see on this was this https://github.com/phpmya dmin/phpmyadmin/wiki/2014-02_Meeting#Mobile_version:_follow-up Also it was mentioned that this feature in right now not in priority. My plan to implement this is to make the interface the mobile first. a) The left side bar with id pma_navigation can be put as the menu/hamburger icon for smaller screens b) The div with id serverinfo will still remain at the top. c) The div with id topmenucontainer will be implemented as the horizontal scrolling like this (Open this link in https://getmdl.io/ components/index.html on mobile you will see the horizontal scrolling at the top for about, getting started etc.) d) The div with id maincontainer will now have the main content. Home page boxes (General settings, Database server etc) can be shown in the vertical order. Right now it works but there is still some spacing issues. Tables can be shown with some min-width because it will not fit on smaller screen sizes when the number of columns in the table are more or they contains large strings like tokens, md5 strings etc. For status tab one more horizontal slider will be required and then the tables one after another in vertical position. e) The div with id pma_console will remain same. when it is opened on smaller devices it will open on the full screen instead of half as in larger screens.
Manish Bisht Email : hi@manishbisht.me Website : https://manishbisht.me
On Wed, Mar 1, 2017 at 2:44 PM, shishir bondre bondreshishir@gmail.com wrote:
What will be necessary features required for the *Theme Generator* and Expectations so that i can propose a good proposal and focus on these features and generate a good idea
On Wed, Mar 1, 2017 at 2:10 PM, Michal Čihař michal@cihar.com wrote:
Hi
Manish Bisht píše v St 01. 03. 2017 v 13:30 +0530:
- Disable charset conversion when importing with SET NAMES
The list comment on this link https://github.com/phpmyadmin/phpmyadmi n/issues/9419 gives the start to solve this issue.
Indeed the charset handling seems to be broken on the import: the iso-8859-1 file imports fine if I choose utf-8 and keep SET NAMES latin1 the iso-8859-1 file imports fine if I choose iso-8859-1 and remove SET NAMES latin1 the iso-8859-1 file imports corrupted if I choose iso-8859-1 and keep SET NAMES latin1
Any suggestions will be helpful to implement it in more better way.
I've already commented on this in the issue tracker:
Not sure how to best approach this, but we should avoid the double encoding problem. On the other side the charset selector for import has to stay for SQL files which do not do SET NAMES and for other formats like CSV. Maybe disable our charset conversion once we spot SET NAMES in the SQL?
If you want to followup, please do that in the issue tracker, so that whole discussion stays in one place.
-- Michal Čihař | https://cihar.com/ | https://weblate.org/
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers