10 Jul
2009
10 Jul
'09
3 p.m.
Hi
Dne Thu, 9 Jul 2009 13:42:06 -0500 Derek Schaefer derek.schaefer@gmail.com napsal(a):
I present to you, all my code to date! If you are curious enough to look over my code, please send me any suggestions that you may have.
- An SVN diff file created against revision 12637 on July 9th
(http://downloads.moonlapse.org/pma/midterm/pma_trunk.diff.zip)
Quick review:
- Please stick with unix end of lines (libraries/import/ods.php) - Please avoid unrelated changes (eg. whitespace), feel free to submit them separately. - Was it really necessary to expand OpenDocumentNS?
Otherwise it looks good, will test it more deeply during weekend.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com