Hello phpmyadmins,
I am new around here, and I would like to submit a small bug fix for [0].
I have read some pages on the website [1], wiki [2] and took a look at
the patch tracker [3]. I understand that I have to either submit a patch
( created with git format-patch, or with git diff between two branches),
or I can post the link to the branch solving the bug on my forked
phpMyAdmin repo [4].
I did not add a patch on the tracker, because I am not sure if that is
the good way to do it, but if I were to do that, I would probably classify
it as "Category -> Debugging", and "Group -> Finished. Needs basic
tests". Is that ok?
The other option would be to post a comment on the bug tracker [0]
with a link to the branch containing my proposed fix on my forked
PMA repo [5]. But on my 3464377 branch, I made more commits to
reach the final desired code : a few test commits, then the actual
code fix commit + a white space delete, then a coding style commit
and finally an undo white space deletion commit :). And I'm not sure
if that's ok. Should I try and merge all those commits into one somehow?
So just in case my repo is not good to merge from, I copied the final
diff on pastebin [6].
And also, I edited the code in netbeans, so I hope there are no other
differences in the white spaces, or any other coding style related issues,
than the ones I spotted. I think that it should be ok, but again, please
correct me if I am wrong. And, of course, any comments about the
actual fix are more than welcome.
Kind regards,
Alex