On Tue, Aug 11, 2009 at 4:11 AM, Michal Čihař
<michal@cihar.com> wrote:
Hi
Dne Tue, 11 Aug 2009 03:35:22 -0400
Zeeshan Mughal <zeeshanmughal@ieee.org> napsal(a):
> I hope my work helps the community, and phpmyadmin's users find it worthy of
> their use. Also, I would appreciate if someone from the developers team can
> assign him to the patch.
First, the patch does not apply:
refs_final.patch
(Stripping trailing CRs from patch.)
patching file db_search.php
(Stripping trailing CRs from patch.)
patching file db_structure.php
(Stripping trailing CRs from patch.)
patching file index.php
(Stripping trailing CRs from patch.)
patching file lang/english-utf-8.inc.php
Hunk #1 succeeded at 1 with fuzz 2.
(Stripping trailing CRs from patch.)
patching file libraries/auth/cookie.auth.lib.php
(Stripping trailing CRs from patch.)
patching file libraries/config.default.php
(Stripping trailing CRs from patch.)
patching file libraries/db_perm.usr.pref.php
(Stripping trailing CRs from patch.)
patching file libraries/db_structure.lib.php
(Stripping trailing CRs from patch.)
patching file libraries/display_tbl.lib.php
(Stripping trailing CRs from patch.)
patching file libraries/footer.inc.php
patch: **** malformed patch at line 541: + } else {
Also please remove not needed things from the patch:
//$cfg['LoginCookieValidity'] =
4646464654654564564654648645645456564465464;
var $link = ''; in permUsrPref class
Other comments:
permUsrPref class should be named PMA_PermUsrPref and it should be
defined in libraries/PermUsrPref.class.php
permUsrPref.table should not be hardcoded, but configurable
You should really use PMA_query_as_controluser
You copy the same code to several places, it should be rather single
include which would provide all what is needed to access preferences.
* @TODO Figure out why SQL queries do not give proper results
- this means that your code does not work?
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel