On Sat, 2011-06-18 at 18:14 +0200, Tyron Madlener wrote:
On Fri, Jun 17, 2011 at 1:29 PM, Rouslan Placella rouslan@placella.com wrote:
On Thu, 2011-06-16 at 22:47 +0200, Piotr Przybylski wrote:
2011/6/16 Rouslan Placella rouslan@placella.com:
On Thu, 2011-06-16 at 21:05 +0200, Piotr Przybylski wrote:
2011/6/16 Rouslan Placella rouslan@placella.com:
Hi there,
I've added some animations to the routines functionalities in my branch and I'm just looking for your opinions about this. A demo video is available on my site [1]. Please let me know if you think that it's too much eye-candy or if you think that it's OK. I didn't check this into my repo yet and I'm keeping the code in my git-stash.
Personally, I don't like the table jumping up and down. Moving objects attract attention, especially if a large part of the screen moves, and in this case it looks like an effect done because it can be done. Space above Routines table should expand / contract to proper height in one move - it it needs two, then the effect stops looking nice, it becomes annoying.
If it can't be done, it would look nice with old content replaced by new with 0 opacity and using fade in to show it.
(Note - I can be prejudiced, I hate collapsible options in PMA because the animation used there is just wrong imo)
Well, I added in the animations because without them the content on the page just flashes and I find that really disturbing, not just because I could (you can see this functionalities without the animations on my demo server). But yeah, you have a good idea there about making the content slide once from the source size to the target size with alpha blending to complement the transition, I'll look into, but it doesn't sound simple to implement and it will probably be CPU intensive.
One effect or the other, two at one will surely be too slow. I think alpha alone would be the simplest to implement, as you just have to replace contents and run the animation.
And I was suggesting the configuration option to disable animations especially for people that are annoyed by them and also for people with old computers :)
Sounds reasonable. I think this could be implemented by setting jQuery.fx.off to true.
I've improved the animation to only slide once during the replacement of the content and uploaded a new demo video [1].
Please let me know what you think.
Agreeing with Piotr, the animation is way more pleasant now. But one other thing looks pretty annoying to me, that is having all these partly useless PMA_ajaxShowMessage()'es pop up and disappear sometimes really so fast you cannot read the content.
- some loading messages flash so quick you don't even know what it is
Those "fast" ajax messages read "Loading..." (as in: loading the content for the dialog, etc), but because I was using the loopback interface on my computer while recording that video, the requests were answered really fast by phpMyAdmin. If you try this on my demo server, you will see that those messages actually stay on for quite a bit.
- messages that display the successful execution are not needed since
you already see the success of the current action in the light green box below the links bar.
Good idea to remove some of those, thanks :)
This applies to many areas in phpmyadmin. In your demonstration the drawbacks of those messages are particularly present though.
In my opinion PMA_ajaxShowMessage() in its current implementation should be thrown out of pma completely. A loading indicator should appear in a small box at the top of the screen like gmail has, success messages should appear in the same way or within a light green box like the ones in rouslans demo video.