> Hi Marc,
>
> Hi,
>> can someone explain the goal of this method? AFAIK it's never called.
>>
>>
> I introduce this method inside PMA_DisplayResults class.
> As you mentioned, this method has used nowhere.
> I thought that this will useful for further improvements as well generally
> getter setter methods use inside classes.
> But not sure it will definitely use in future.
>
> It can be removed since it is not using at the moment.
> What should be better ?
>
> Regards !
Chanaka,
I'm not sure, let's see opinions of others on this.
I think, as to set the local PMA_CommonFunctions object of any class using setCommonFunctions(), we would always need the existing single object using PMA_CommonFunctions::getInstance().
And when we use local getCommonFunctions(), it already sets the local PMA_CommonFunctions object to PMA_CommonFunctions::getInstance(). So I see no particular utility of setCommonFunctions().
Hi Marc,
I introduce common setter method for set any property of that class.
So I'll remove
setCommonFunctions() function since the expected behavior can obtain from the common setter.