On Mon, Aug 1, 2011 at 3:24 PM, Piotr Przybylski <piotr.prz@gmail.com> wrote:2011/8/1 Rouslan Placella <rouslan@placella.com>:
I noticed that the JS code that handles the recent tables in the
navigation frame operates under the assumption that there will only ever
be one dot in the database+table string. This is not true. To reproduce
the problem:
* create database 'abc.def'
* in this database create table 'ghi'
* browse this table
* now select it from the recent table dropdown
* you are dropped to main.php because PMA is looking for database 'abc'
and table 'def' (the 'ghi' part is discarded)
I'm not saying that it's sane to put dots in the database name, but it's
certainly legal. So maybe the check should be for the last occurrence of
a dot...
Then we will still have problems with dots in table names. From what
you are saying it looks like this should be changed to get these names
from some other place.
Indeed. Dots in identifiers was not an issue before MySQL 5.1.6. Butafter 5.1.6 you can have dots everywhere (db names, tables, columns,etc..).This new behavior is documented athttp://dev.mysql.com/doc/refman/5.1/en/identifiers.html
Oh, right. I missed this part in MySQL docs. I will fix this soon.
Thanks for the feedback. :)
--
Aris Feryanto