Hi Marc,<br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ok, so what do you think of this code snippet:<br>
<br>
$query[] = $insert_command . &#39;INTO &#39;<br>
 . PMA_CommonFunctions::getInstance()-&gt;backquote($GLOBALS[&#39;db&#39;]) . &#39;.&#39;<br>
 . PMA_CommonFunctions::getInstance()-&gt;backquote($GLOBALS[&#39;table&#39;])<br>
        . &#39; (&#39; . implode(&#39;, &#39;, $query_fields) . &#39;) VALUES (&#39;<br>
        . implode(&#39;), (&#39;, $value_sets) . &#39;)&#39;;<br>
<br>
Does this follow the singleton principle?<br></blockquote><br></div>As I think this doesn&#39;t break the singleton principle since we are not creating two objects.<br>Since the private constructor always give the existing PMA_CommonFunctions object if there exist any, no more objects are created.<br>
<br>Actually why I used that $common_functions variable is, reducing the line length and if there are frequent occurrence inside procedural code or function, its easy to use a variable than this lengthy code.<br>As well we have discussed to reduce the use of globals.<br>
<br>Please make me correct if I did any wrong.<br>  <br clear="all">Regards !<br>-- <br>____________________________________<br><br>Chanaka Indrajith<br>Bsc.Computer Engineering Undergraduate<br>Faculty of Engineering<br>
University of Peradeniya<br>Sri Lanka<br>____________________________________<br><br>