On Tue, Jan 6, 2015 at 1:28 PM, Madhura Jayaratne <madhura.cj@gmail.com> wrote:


On Mon, Jan 5, 2015 at 10:17 PM, Smita <kumarismita62@gmail.com> wrote:
On Mon, Jan 5, 2015 at 8:15 PM, Marc Delisle <marc@infomarc.info> wrote:
Smita a écrit :
> On Mon, Jan 5, 2015 at 6:19 PM, Marc Delisle <marc@infomarc.info> wrote:
>
>> Smita a écrit :
>>> Hi
>>>
>>> In current master branch, on table structure page, if I click on "change"
>>> corresponding to any column, I get lots of JS error. It starts with:
>>>
>>> "NetworkError: 500 Internal Server Error -
>>> http://localhost:8080/phpmyadmin/js/messages.php?lang=en&db=foodo&
>>> token=XXXXXXXXXX"
>>> "NetworkError: 500 Internal Server Error -
>>> http://localhost:8080/phpmyadmin/js/whitelist.php?lang=en&db=foodo&
>>> token=XXXX"
>>>
>>> followed by flooding of reference errors:
>>> ReferenceError: PMA_messages is not defined
>>>
>>> I am wondering if its just me having this problem or anyone else getting
>>> the same?
>>>
>>> Thanks and Regards
>>> --
>>> Smita K.
>> Hi Smita,
>> I tested with 495250f8cb39c6ed85505bd9c97587fc12a15b8c. All seems to be
>> fine in the UI, but in the web server's error log I get:
>>
>> PHP Fatal error:  Call to a member function getTables() on a non-object
>> in libraries/relation.lib.php on line 1890.
>>
>> Hi Marc
>
> yeah right, I just checked my server error log, I am also having the same
> Fatal error.  I'm looking into it, 'll update if I can get what is causing
> it.

git bisect should help you, see
https://wiki.phpmyadmin.net/pma/Git#Finding_problematic_commit

Git bisect is amazing. thanks.
I get "89de2f6227b5bf37f07c18352e893eff83937d1c is the first bad commit". But I don't see any reason for this commit to cause the problem. am i getting it wrong ?
Btw in libraries/relation.lib.php on line 1890, simply keeping isset check on $GLOBALS['dbi'] fixes the issue.


I think it's better to figure our the cause of the problem first rather than using a isset check here.

yeah, agree with you. that's why i didn't commit.
--
Thanks and Regards,

Madhura Jayaratne


------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel