On Sat, 2011-06-11 at 21:23 -0700, Aris Feryanto wrote:
Hi Rouslan,
----- Original Message -----
From: Rouslan Placella rouslan@placella.com
On Sat, 2011-06-11 at 10:58 +0700, Aris Feryanto wrote:
On 10 Jun 2011, at 20:31, Marc Delisle marc@infomarc.info wrote:
I've updated my repo and it should be available in the demo soon. I add
small popup balloon when we hover the column header. I also add some css code to prettify the column dragging. Please kindly check this.
P.S.: All my changes for column resize and reorder can be found under
"colresize" branch in my git repo.
I found a small bug with the tooltip. See video here: http://www.placella.com/pma/colreorder_bug.avi
Thank you for reporting this. It is nice to show that in the video. I tested in some browsers (chrome, firefox, IE) and found that the bug only occurred in firefox/ubuntu. I've fixed this in my git repo.
It works great now. By the way, I found another few small issues that you might want to look at :)
You hard-coded a lot of sizes in CSS in px units. So now items don't really scale. For example, go to main PMA page and from the dropdown select font size of, for example, 132%. Now go to browse a table and hover the column header. You will see your "Drag to reorder" hint is the same as when the font size was set to 82%, but instead it should be bigger. You can use the 'em' unit instead of the 'px' unit in CSS to fix this.
Also, while resizing a column, the "Drag to reorder" hint keeps trying to pop out when you hover the label of the column. And when you resize the column to a small size, about 10px, and then hold the mouse still a bit both the hints for sorting and reordering pop out (see attached screenshot). And at this point I think that "Sort" alone doesn't mean much any more, so in my opinion the two hints should be merged into one like "Drag to Reorder <br /> Click to Sort".
Rouslan
