On Wed, May 30, 2012 at 1:53 AM, Marc Delisle <marc@infomarc.info> wrote:

Le 2012-05-29 15:34, Atul Pratap Singh a écrit :

> On Tue, May 29, 2012 at 10:04 PM, Marc Delisle <marc@infomarc.info> wrote:
>
>> Le 2012-05-29 10:46, Atul Pratap Singh a écrit :
>>> Hi Marc,
>>> While looking at "tbl_zoom_select.php":-
>>>
>>> Line 191-201
>>> if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] !=
>>> 'pma_null')) {
>>> $flag = 2;
>>> for ($i = 0 ; $i < 4 ; $i++) {
>>> if ($inputs[$i] != 'pma_null') {
>>> $key = array_search($inputs[$i], $fields_list);
>>> $tbl_fields_type[$i] = $fields_type[$key];
>>> $tbl_fields_collation[$i] = $fields_collation[$key];
>>> $tbl_fields_null[$i] = $fields_null[$key];
>>> }
>>> }
>>> }
>>>
>>> As the condition would be true in cases when post param $inputs is set
>> and
>>> has index 0 or 1 set to some column name. It would mostly happen if a
>> half
>>> or full filled search form is submitted, but there seems to be no further
>>> use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type
>>> gets used afterwards with indexes >= 4.
>>
>> Atul,
>> Indeed, $tbl_fields_collation and $tbl_fields_null could be removed.
>>
>>
>>> I think as a result after the zoom plot is displayed, clicking at "show
>>> search criteria" doesn't show any previously filled criteria.
>>
>> Well, I see the chosen two column names, but indeed there seems to be a
>> bug because at least the operator and value should be displayed.
>>
> Ok Marc, I'll remove the bug and also any unused variables.

The bug was introduced by
https://github.com/phpmyadmin/phpmyadmin/commit/9be5d8e02ae431be040e655da0eb39b134cd107d.

Beware that js/tbl_zoom_plot.js has been renamed to
js/tbl_zoom_plot_jqplot.js when I made the changes from Highcharts to
jqplot.

Thanks Marc,

I have tried to fix the bug for now. Please check [0].

Also, I have noticed that in case of updating the field information using AJAX (line 91) the class="textfield datetimefield" attribute doesn't work and a timestamp type field is also displayed with simply an input box.

1. Open zoom search for a table with at least a field of timestamp type

2. Select the timestamp type column from dropdown.

3. Notice simply an input box without datepicker.

[0] https://github.com/zixtor/phpmyadmin/commit/b37066c4a4cf9b19ee98742837b01fb21d89abb4

>
>>
>>> I also didn't understand the use of $flag variable.
>>
>> This must have been some debugging info, you can safely remove it.
>>
>>>
>>> Thanks
>>>
>>>
>>>
>>>
>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>
>>>
>>>
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
>> --
>> Marc Delisle
>> http://infomarc.info
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
>
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
>
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

--
Marc Delisle
http://infomarc.info

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel