On Tue, 2011-10-11 at 10:26 +0100, Rouslan Placella wrote:
On Tue, 2011-10-11 at 01:57 +0200, Piotr Przybylski wrote:
2011/10/11 Rouslan Placella rouslan@placella.com:
On Mon, 2011-10-10 at 22:42 +0200, Piotr Przybylski wrote:
It still caused scrollbars to appear, so I tried to change Marc's approach - now window's scrollbars should be inactive, only dialog's content should have them [1]. While at it, I also upgraded jQuery UI to the newest stable version [2].
I'm not convinced that this is better. Try the following scenario:
- Open a somewhat small browser window.
- Click Create table.
- Maximise the browser window.
The dialog remains the same size, is padded with a lot of white space and there is no way to resize it, so the user has to close and reopen it. Same goes for making the browser window smaller after opening the dialog: you can't resize it, so you end up with two sets of scrollbars anyway.
What browser are you using? There is a callback that should be reacting to window's resize.
So far I tried (under linux): Firefox 7, Opera 11 and Chromium 12. The issue is present in all of them. I also tried IE8, where it doesn't seem to work at all. Clicking the create table icon opens an unusable dialog. See attached screenshot.
I see a commit that fixes the resize issue, so after pulling from master this issue is gone. The IE problem still applies though.
I hope I didn't break anything in the process, and that new dialog works better.
[1] http://phpmyadmin.git.sourceforge.net/git/gitweb.cgi?p=phpmyadmin/phpmyadmin... [2] http://phpmyadmin.git.sourceforge.net/git/gitweb.cgi?p=phpmyadmin/phpmyadmin...
Also I'm not sure why you committed the following:
--- a/js/functions.js +++ b/js/functions.js @@ -1433,6 +1433,8 @@ function PMA_ajaxRemoveMessage($this_msgbox) // due to a bug in qtip's implementation we can // only hide it without throwing JS errors. $this_msgbox.qtip('hide');
} else {$this_msgbox.remove(); }}
This change looks irrelevant to your work and besides the messages are destroyed at line 1388 via a callback, so this change may cause conflicts though I haven't verified this.
Unless I misunderstood something this should destroy message completely, and I needed this change because the way in which I am hiding page's content makes recent AJAX message to come back when I close create table dialog. It's in the same commit as dialog's change for easy rollback.
Sorry about that comment, I see now what that does.
Rouslan
All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel