2011/10/19 Marc Delisle marc@infomarc.info:
Hi,
Tyron Madlener suggested to get rid of the title bar in the create table dialog.
I've come up with this patch (done here just for pmahomme):
diff --git a/js/functions.js b/js/functions.js index 19ab7ce..d171496 100644 --- a/js/functions.js +++ b/js/functions.js @@ -1514,7 +1514,6 @@ function PMA_createTableDialog( $div, url , target) $div .append(data.error) .dialog({
- title: PMA_messages['strCreateTable'],
height: 230, width: 900, open: PMA_verifyColumnsProperties, @@ -1528,7 +1527,7 @@ function PMA_createTableDialog( $div, url , target) $div .append(data) .dialog({
- title: PMA_messages['strCreateTable'],
- dialogClass: 'create-table',
resizable: false, draggable: false, modal: true, diff --git a/js/messages.php b/js/messages.php index 96f759b..71afc05 100644 --- a/js/messages.php +++ b/js/messages.php @@ -222,7 +222,6 @@ $js_messages['strReloadDatabase'] = __('Reload Database'); $js_messages['strCopyingDatabase'] = __('Copying Database'); $js_messages['strChangingCharset'] = __('Changing Charset'); $js_messages['strTableMustHaveAtleastOneColumn'] = __('Table must have at least one column'); -$js_messages['strCreateTable'] = __('Create Table'); $js_messages['strYes'] = __('Yes'); $js_messages['strNo'] = __('No');
diff --git a/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css b/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css index a712408..a087015 100644 --- a/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css +++ b/themes/pmahomme/jquery/jquery-ui-1.8.16.custom.css @@ -437,6 +437,7 @@ button.ui-button::-moz-focus-inner { border: 0; padding: 0; } /* reset extra pad */ .ui-dialog { position: absolute; padding: .2em; width: 300px; overflow: hidden; } .ui-dialog .ui-dialog-titlebar { padding: .4em 1em; position: relative; } +div.create-table .ui-dialog-titlebar {display: none; } .ui-dialog .ui-dialog-title { float: left; margin: .1em 16px .1em 0; } .ui-dialog .ui-dialog-titlebar-close { position: absolute; right: .3em; top: 50%; width: 19px; margin: -10px 0 0 0; padding: 1px; height: 18px; } .ui-dialog .ui-dialog-titlebar-close span { display: block; margin: 1px; }
Questions:
What do you think of this patch?
Should we instead remove the title bar for all our jQuery dialogs?
P.S. We'll need to be extra careful when updating the jquery ui, by reinserting phpMyAdmin's customizations under themes.
I don't like adding CSS rules to jquery-ui-1.8.16.custom.css. IMO we should do this in theme's CSS or a separate file. Or at the bottom of jquery-ui-1.8.16.custom.css, in a commented section - then future updates of jQuery UI will be simple. Right now it requires to check what changes were done since last update and apply them to new version.