[Phpmyadmin-devel] sqlparser.lib.php PMA_SQP_typeCheck()?

30 Jan 2007

      hi,

it seems PMA_SQP_typeCheck() is not used anywhere

and even if used - i think this function does not work as expected

$typeSeperator = '_';
if (strcmp($whatWeWant, $toCheck) == 0) {
     return TRUE;
} else {
     if (strpos($whatWeWant, $typeSeperator) === FALSE) {
         return strncmp($whatWeWant, $toCheck, strpos($toCheck, 
$typeSeperator)) == 0;
     } else {
         return FALSE;
     }
}

the second 'if' should compare to !== false

or did i missed something?

-- 
Sebastian Mendel

www.sebastianmendel.de