Hi,

2013/12/22 Michal Čihaø <michal@cihar.com>
Hi

Dne Sat, 21 Dec 2013 22:25:09 +0100
Hugues Peccatte <hugues.peccatte@gmail.com> napsal(a):

> Hi,
>
> 2013/12/20 Michal Čihaø <michal@cihar.com>
>
> > Hi
> >
> > Dne Fri, 20 Dec 2013 07:37:19 +0100
> > Hugues Peccatte <hugues.peccatte@gmail.com> napsal(a):
> >
> > > Ok, thanks, I'll look at this and see if new rules seem useful.
> > > I didn't think to look in PMD. In my job, all this work is done by PHPCS
> > > and I didn't know PMD could do the same...
> > >
> > > So... I'll look at PMD to see what I could "improve" in the source code.
> >
> > Honestly it would be better to have just one tool doing this as it
> > would run faster, I just wanted to point out there is something else
> > available as well.
> >
>
> Michal, could you please tell me where are defined the rules used by PMD
> please ?

They are part of phpmd, I don't think we change them anyhow.

I'm still thinking about PHPCS and PMD and I've some questions:
- would you agree to only use PHPCS if possible ? I would like to see if it's possible to use all the PMD rules (or equivalent) in PHPCS.
- how could you not have this error http://phpmd.org/rules/controversial.html#camelcasepropertyname on Jenkins ? On my IDE, I activated all PMD rules and I've the error in file /libraries/config/ConfigFile.class.php because of property $_defaultCfg (and others which have a leading underscore).

Thanks for your answers.

And Merry Christmas to everyone.

Hugues.


--
        Michal Čihaø | http://cihar.com | http://phpmyadmin.net

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel