22 Jul
2015
22 Jul
'15
1:38 p.m.
On Wed, Jul 22, 2015 at 2:03 PM, Hugues Peccatte <hugues.peccatte(a)gmail.com>
wrote:
Le mer. 22 juil. 2015 à 10:13, Nisarg Jhaveri
<nisargjhaveri(a)gmail.com> a
écrit :
Yes, I see it now. I'll send a PR fixing it soon. Thanks for pointing it
out.
--
Nisarg Jhaveri
નિસર્ગ ઝવેરી
On Tue, Jul 21, 2015 at 1:37 AM, Hugues Peccatte <
hugues.peccatte(a)gmail.com> wrote:
Hi,
Maybe I miss something, but :
- HTML is returned from PMA_displayGroupHeader in $htmlOutput here:
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/config/FormD…
- $htmlOutput is unused as empty return is done here:
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/config/FormD…
As PMA_displayGroupHeader doesn't display anything, I'm afraid that its
return is lost.
Do you see what I mean?
H.
Hi,
@Nisarg, since commit 3fcd07ac19b1a047d159794750d6cf0350f1f3a2, in
libraries/config/FormDisplay.class.php:425, a HTML return is unused.
Before, the return was echoed. But now it is lost.
Can you have a look about this please?
Thanks,
H.
Hi,
The commit you mentioned was in continuation with
431847b39ea32cbd20a7e58117df5029540f0e3c. I believe that the HTML is
returned properly. The returned HTML from
`FormDisplay->_displayFieldInput()` is finally used in
`FormDisplay->getDisplay()` which is used at several places.
I hope I understood your concern correctly. Is there some place where it
is not showing correctly or something?
--
Nisarg Jhaveri
નિસર્ગ ઝવેરી