On Thu, Jun 29, 2017 at 6:39 PM, Michal Čihař <michal@cihar.com> wrote:

Hello

Manish Bisht píše v Čt 29. 06. 2017 v 14:12 +0530:
> I have almost made phpmyadmin responsive. Now only the designer tab
> is remaining. Have a look into this branch for review: https://github
> .com/manishbisht/phpmyadmin/blob/responsive-design/
>
> I am looking forward for your suggestions and feedback

Unfortunately I didn't yet get to deeper testing, but a little bit of
feedback on the code:

- avoid including commented out debug statements (//console.log(wmax);)
- you'we commented out most of  PMA_tbl_structure_menu_resizer_callback
and it now doesn't return value as it used to
- you probably want to regenerate sprites to include left and right
icons

--
        Michal Čihař | https://cihar.com/ | https://weblate.org/

_______________________________________________
Developers mailing list
Developers@phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers