Re: [Phpmyadmin-devel] about merging $what and $query_type on libraries/mult_submits.inc.php

Hi Marc, my meaning is that, from the code, $what and $query_type are used for different actions. $what: case 'add_prefix_tbl': case 'replace_prefix_tbl': case 'copy_tbl_change_prefix': case 'drop_db': case 'drop_tbl': case 'empty_tbl': $query_type: case 'check_tbl': case 'optimize_tbl': case 'repair_tbl': case 'analyze_tbl': ........ these two kinds of different actions have different logic of code to hanldle it. branch 1 : about $what : https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits… branch 2: about $query_type: https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits… If we merge them together, the two branches should be merged as well. so the logic will be more complicated. so I think the better way is to re-name these two variables to a meanningful name. what do you think?