Marc Delisle a écrit :
陈岳峰 a écrit :
Hi,
I can see the log
commit f337248acce77a4ea3c13c96fffa813f218cf5e3 Author: dennischen <dennislyve@gmail.com mailto:dennislyve@gmail.com> Date: Mon Mar 14 14:16:17 2011 +0800
for Server_variablescommit f1ac81605e230c3d2c81e883499fcef42e2c4b57 Author: dennischen <dennislyve@gmail.com mailto:dennislyve@gmail.com> Date: Mon Mar 14 14:11:09 2011 +0800
Server Variables--ID: 3196075do I commit the code to the official repo or somewhere else?
First, in this mailing list, please do not top-post, it's difficult to read.
Second, about your question. I did not say that you did not commit, I said that you did not push. Seeing the commit lines in the log means that you committed to your local repo, but unless you push to the remote repo, we cannot see your work.
Today I see that you have pushed to the remote repo so we'll be able to look at your work.
Your patch works correctly, if I use commit f337248acce77a4ea3c13c96fffa813f218cf5e3.
Beware that later in commit 4e39b62a2a00a5a624dfae5874a85a88a398edd8 you _reverted_ a commit so your latest repository does not contains the changes that make each variable clickable and shows the tooltip.