Le 2013-07-15 10:44, Supun Nakandala a écrit :

> Hi devs,
> I am facing a difficulty in setting up the goals for the week 5. I think
> I have considerably refactored the sql.php using extract method. I would
> like to hear from you whether I should consider further refactoring
> using extract method or any other suggestions to work on during the next
> week.
>
> Regards Supun

Hi Supun,

Regarding code extraction, I think we are fine. However, here is what I
told you on June 24 on this list, regarding sql.php:

-------
as discussed previously, your proposal says "The sql.php is a
very large script and is also one of the central components in
phpMyAdmin. As it is large it is hard to read and maintain. It needs
refactoring and better integration with other scripts calling it."

So, all scripts that are including sql.php (for example db_qbe.php)
should probably be including a library file then call a high-level
function. Hint: sql.php's main job is to deal with $sql_query.
-------

In summary, you should transform all places where we include sql.php, to
a function call that deals with $sql_query.

--
Marc Delisle
http://infomarc.info

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel