On Wed, Oct 2, 2013 at 10:39 PM, Marc Delisle <marc@infomarc.info> wrote:
Atul Pratap Singh a écrit :
> On Wed, Oct 2, 2013 at 10:04 PM, Marc Delisle <marc@infomarc.info> wrote:
>
>> Marc Delisle a écrit :
>>> Hi,
>>> can someone reproduce this problem in master (is also present for me in
>>> 4.1.0-alpha1):
>>>
>>> Using cookie auth_type, you logout and get two js errors in the console
>>> (seen in Firefox 23 under Windows 7).
>>>
>> Confirmation, anyone? Because if confirmed (and when fixed) I would like
>> to publish 4.1.0-alpha2 soon.
>>
>> git bisect tells me:
>>
>> ed3171cb8705e6cdc827f7bd8eb9cf7a5acb51ea is the first bad commit
>> commit ed3171cb8705e6cdc827f7bd8eb9cf7a5acb51ea
>> Author: Mohamed Ashraf <mohamed.ashraf.213@gmail.com>
>> Date:   Tue Sep 3 15:53:51 2013 +0200
>>
>>      Fixed testcases that test the script class
>>
>> I also reproduced the problem, to me git bisect tells, first bad commit is:
>
> 3541a6d2b59fcfaedf8250016afd84321211f3b9 is the first bad commit
> commit 3541a6d2b59fcfaedf8250016afd84321211f3b9
> Author: Mohamed Ashraf <mohamed.ashraf.213@gmail.com>
> Date:   Mon Jun 24 15:38:13 2013 +0200
>
>     error reporting now respects settings

Doing a checkout of 3541a6d2b59fcfaedf8250016afd84321211f3b9, on the
login page I only see the logo and welcome message, no login dialog. So,
for me, this commit shows a different problem than the logout problem.

Marc,
Same for me, but on checking out the parent of 3541a6d2b59fcfaedf8250016afd84321211f3b9 i.e. 3b9fad42e09abc62442bdf63675f03d8acd7fce5, logout work fine for me.

Whereas, on checking out parent of
ed3171cb8705e6cdc827f7bd8eb9cf7a5acb51ea, I get an empty page..

Further, removing require_once './libraries/common.inc.php' from js/get_scripts.js.php solves the problem, but it seems vital for error reporting server.. So, I think Mohamed can tackle this better..


--
Atul Pratap Singh
http://blog.atulsisodia.in/