On Fri, May 20, 2011 at 1:05 PM, Piotr Przybylski <piotr.prz(a)gmail.com> wrote:
2011/5/20 Tyron Madlener <tyronx(a)gmail.com>om>:
On Fri, May 20, 2011 at 12:14 PM, Piotr
Przybylski <piotr.prz(a)gmail.com> wrote:
2011/5/20 Tyron Madlener
<tyronx(a)gmail.com>om>:
On Mon, May 16, 2011 at 8:07 PM, Tyron Madlener
<tyronx(a)gmail.com> wrote:
What I've implemented now quick'n'dirty:
- Word filtering on the variables page
- Server status page:
- filtering by category
- when filtering by category, or typing a category name it will
display related links which formerly were at the bottom of each table
- i've added a jquery table sorter (12k unminified) to allow table
sorting (currently sorting indicators are missing)
- i've added the jquery cookie plugin (3.6k unminified) to allow
cookie persistence for jquery tabs
[...]
Do we really need this? If so, at least change cookie name from
"ui-tabs-1" to something more descriptive.
I've added those two jquery plugins more like for demonstrational
reasons. It only requires 2 small changes to remove either plugin. But
counter question: Why we shouldn't use it? If a person checks up on a
server variable several times, we save him a mouse click. Save a
second, save a life ;)
Ok, I can't argue with that :)
But when talking about whether we really need
this:
- From what I can see there's lots of jQuery UI components included
that are not used. We could remove those.
- We can delete jquery/timepicker.js because it's redundant. I just
deleted it and removed the includes in tbl_change.php and
tbl_select.php - the datepicker still works since its included in
jquery-ui-1.8.custom.js.
I'm not sure how this custom version was generated but if you are
removing jQuery UI features, add some docs which will let the next
person that generates jquery-ui-*-custom.js get the components we
require. Or is there already such a list somewhere?
Not that I know of. Who included it in the first place? Probably a
good idea to start a page on the wiki for that. As for now, I removed
timepicker.js from my branch.
Unfortunately I cannot change the cookie name
that easily. Naming is
done through the jquery tab plugin.
Then maybe it is based on tab control's id or something similar? If
it's done by plugin, I believe there has to be an easy way to
influence this. Otherwise, you are limited to one tab per domain,
which seems silly.
If the automatic way doesn't work correctly, try submitting a bug
report to jQuery UI, or use tab's show event to set cookie.
Oh right. Looking at the code, you can actually can pass a cookie name
to it. My bad, I must have overlooked it.
--
Piotr Przybylski