Re: [Phpmyadmin-devel] #4536 - master: import problem (PMA_String)

Le 2014-09-29 08:02, Marc Delisle a écrit :

Hugues Peccatte a écrit :

...

2014-09-28 22:35 GMT+02:00 Marc Delisle marc@infomarc.info:

...

Le 2014-09-28 15:53, Hugues Peccatte a écrit :

...

2014-09-28 14:17 GMT+02:00 Hugues Peccatte <hugues.peccatte@gmail.com mailto:hugues.peccatte@gmail.com>:

2014-09-26 23:35 GMT+02:00 Hugues Peccatte
<hugues.peccatte@gmail.com <mailto:hugues.peccatte@gmail.com>>:

    Hi,

    I'll see how to add a comment. PHPCS will curse us for too long
    lines. :)

    I just found a limit to this method: the tests.
    If mb_* functions exist, we won't be able to create our mb_*
    functions and so to test it.

    Even if there is this issue, I'm currently working on this new
    "pattern".

    Hugues.


Hi,

I created the new mb_* functions and initialised the unit tests.

As I said, we won't be able to run tests for native mb_* functions
and PMA mb_* functions (aliases for standard string functions) on
the same environment.
Do you think that it would be possible to ask travis to run tests on
a server without multibytes functions please?

Thanks,
H.

Hi everyone,

Work is not over, there are still some errors, but it's partially done. See [1]. Marc, import seems to work (at least SQL, I didn't try with compressed ones). Could you please try to import your SQL file and confirm that you can import structure and data in a reasonable time?

Hi Hugues, Fatal error: Call to undefined function mb_chr() in libraries/Util.class.php on line 4448

...

[1] https://github.com/Tithugues/phpmyadmin/tree/stringFunctions_master

Thanks, Hugues.

Marc,

Do you have multibytes functions on your server please?

Hugues.

Yes, I have the mbstring extension (it's PHP 5.6.0).

Hi Hugues, I retested this morning on a laptop, importing a SQL file containing 10000 employees from the sample employees database. This is a small file (660 KB).

Current master: 3 min 25 sec (and ends with JSON.parse: unexpected character)

Current Tithugues/stringFunctions_master: 2 min 10 sec (same js error)

Current QA_4_2: 0 min 5 sec

There has been improvement, but we cannot release 4.3 with this import speed.