On Fri, Jul 15, 2011 at 1:27 PM, Rouslan Placella rouslan@placella.com wrote:
On Thu, 2011-07-14 at 21:25 -0700, Aris Feryanto wrote:
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-07-13 21:57, Aris Feryanto a écrit :
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter,
"content"
*. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
Aris, column highlighting conflict is fixed, however the problem under IE9 persists: I can't read a thing in these tooltips.
Fixed in my git. After went through the qTip code, I found there was a bug in qTip. The bug make tooltips initialized with empty string always have 20px width in (my) IE. I'll report this bug to qTip community.
Thank you for the feedback.
I'd say don't bother reporting that to the qTtip crowd since qTip 1 is deprecated (the version we use), they are working on qTip 2, which is not yet released (yeah, I know, that makes no sense...).
By the way, now we have 2 different types of tooltips, I'd love to see them being unified some how. The other kind of tooltips are also created in functions.js, by function initTooltips(). So maybe PMA_createqTip() can be used to create those, too. Also the two functions should be phisically next to each other in the file, since they are kind of related. And the cherry on the cake would be if these two types of tooltips could be styled in a similar way and thus look more consistent.
Rouslan
The style can be similar but I still think it's good to have them differ slightly for the 2 different uses. One for hints such as "Hey you can sort this table by clicking the columns" and the others for longer footnotes and explanations.
So I find it great that Aris' tooltip is fancy and animated for the first case.
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel