Thanks Mauricio for your suggestions. Although I've been working on the project in the main repository as of now, I think keeping it in a separate repository would defy one of it's purposes of making it more user friendly by not copying the theme files in the main project. Also, as Isaac mentioned earlier that the feature would not be used generally on small screens I'm dropping the idea of using Bootstrap.

On Mon, May 21, 2018 at 8:47 AM, Maurício Meneghini Fauth <mauriciofauth@gmail.com> wrote:


On Thu, May 17, 2018 at 7:56 AM, Isaac Bennetch <bennetch@gmail.com> wrote:
Hello developers,

Hello,
 

Saksham and I were discussing the theme generator and
responsive/mobile design. My opinion is that this is a rather advanced
feature that will be rarely used, and will have such a large volume of
information that a user would not benefit from using it on a small
screen.

Second, Saksham would like to introduce Bootstrap here to manage the
layout and preview of the interface. Bootstrap is available as a
Composer project. I'm not keen on introducing more dependencies to the
project but want to discuss it with the rest of the group.

I don't see any problem if the Theme Generator is in a separate repository. Actually I even think it's a good idea.

But I find it a bit complicated to add Bootstrap if the theme generator is distributed with phpMyAdmin. I don't think it's a good idea to add that dependency. I think this can bring more problems than solutions. I'm not against using Bootstrap as a CSS framework for phpMyAdmin. I find this very interesting indeed. However this may require a lot of work for a GSoC project that has another goal.
 

Any input on either of these two items?

_______________________________________________
Developers mailing list
Developers@phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers


_______________________________________________
Developers mailing list
Developers@phpmyadmin.net
https://lists.phpmyadmin.net/mailman/listinfo/developers