2011/6/2 Dieter Adriaenssens dieter.adriaenssens@gmail.com:
2011/5/31 Piotr Przybylski piotr.prz@gmail.com:
2011/5/31 Dieter Adriaenssens dieter.adriaenssens@gmail.com:
Hi Piotr,
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Ok, changed to `Server'.
Looks good.
I noticed that the '?' icon next to 'Server connection collation' links to the MySQL documentation. This should point to the Drizzle documenation, to avoid confusion. But I guess there are a whole lot more links to MySQL documentation that should point to Drizzle documentation. Did you put it in your planning to change the documentation links?
No, it's something that should be done at the end of GSoS, provided that Drizzle documentation becomes usable at that point. Right now it's far from complete and contains some obsolete information. I saw on their mailing list that there are plans to improve it, we can only hope it happens soon enough.