A large subset of phpmyadmin users are not the ones who deployed it. we need a place to put the settings for error reporting where unpriviliged users can change them. Is the normal settings page available for all users or can it be hidden by those offering limited services such as shared hosting providers. Also in which tab should I put my settings or should put them in a tab of it own.
On 06/13/2013 08:51 AM, Mohamed Ashraf wrote:
A large subset of phpmyadmin users are not the ones who deployed it. we need a place to put the settings for error reporting where unpriviliged users can change them. Is the normal settings page available for all users or can it be hidden by those offering limited services such as shared hosting providers. Also in which tab should I put my settings or should put them in a tab of it own.
Well, there should be two configuration settings. The first one is whether the feature is enabled or disabled. I think that this setting should be only controlled by the administrators of the installation. And therefore, should not be visible in the user preferences. It should, however, appear in the setup scripts.
The second settings defines the default action to take when an error is encountered (values: 'Always Ask', 'Submit Reports Without Asking', 'Never Submit Reports'). I think that the users should be able to override this setting in the user preferences and when a error prompt pops up. I also think that this settings should not be shown in the user preferences if the feature is disabled (a simple if statement somewhere in the code should accomplish this).
As for the tab, I think that "Feature" -> "General" will be fine.
I'm not sure if I've actually answered your question here, but I hope this helps anyway...
Bye, Rouslan
On Thursday, June 13, 2013 at 7:12 PM, Rouslan Placella wrote:
Well, there should be two configuration settings. The first one is whether the feature is enabled or disabled. I think that this setting should be only controlled by the administrators of the installation. And therefore, should not be visible in the user preferences. It should, however, appear in the setup scripts.
I think i can include it in the config.php file with the other params such as the enabling and disabling of the different components such as bookmarks and the sorts.
I'm not sure if I've actually answered your question here, but I hope this helps anyway...
No that was great
On 06/13/2013 08:09 PM, Mohamed Ashraf wrote:
On Thursday, June 13, 2013 at 7:12 PM, Rouslan Placella wrote:
Well, there should be two configuration settings. The first one is whether the feature is enabled or disabled. I think that this setting should be only controlled by the administrators of the installation. And therefore, should not be visible in the user preferences. It should, however, appear in the setup scripts.
I think i can include it in the config.php file with the other params such as the enabling and disabling of the different components such as bookmarks and the sorts.
We don't actually have a config.php file. IIRC, the config settings for the setup scripts go into libraries/config.*.php files.
I'm not sure if I've actually answered your question here, but I hope this helps anyway...
No that was great
On Thursday, June 13, 2013 at 11:00 PM, Rouslan Placella wrote:
On 06/13/2013 08:09 PM, Mohamed Ashraf wrote:
On Thursday, June 13, 2013 at 7:12 PM, Rouslan Placella wrote:
Well, there should be two configuration settings. The first one is whether the feature is enabled or disabled. I think that this setting should be only controlled by the administrators of the installation. And therefore, should not be visible in the user preferences. It should, however, appear in the setup scripts.
I think i can include it in the config.php file with the other params such as the enabling and disabling of the different components such as bookmarks and the sorts.
We don't actually have a config.php file. IIRC, the config settings for the setup scripts go into libraries/config.*.php files.
I put them in config.sample.inc.php and libraries/config.default.php
I'm not sure if I've actually answered your question here, but I hope this helps anyway...
No that was great
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2013/6/14 Mohamed Ashraf mohamed.ashraf.213@gmail.com:
On Thursday, June 13, 2013 at 11:00 PM, Rouslan Placella wrote:
On 06/13/2013 08:09 PM, Mohamed Ashraf wrote:
On Thursday, June 13, 2013 at 7:12 PM, Rouslan Placella wrote:
Well, there should be two configuration settings. The first one is whether the feature is enabled or disabled. I think that this setting should be only controlled by the administrators of the installation. And therefore, should not be visible in the user preferences. It should, however, appear in the setup scripts.
I think i can include it in the config.php file with the other params such as the enabling and disabling of the different components such as bookmarks and the sorts.
We don't actually have a config.php file. IIRC, the config settings for the setup scripts go into libraries/config.*.php files.
I put them in config.sample.inc.php and libraries/config.default.php
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I'm not sure if I've actually answered your question here, but I hope this helps anyway...
No that was great
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I read the files in the setup directory however I am not sure how to add my setting to the setup script. there seems to be some way the forms are automatically generated however I do not seem to be able to reverse engineer it.
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I read the files in the setup directory however I am not sure how to add my setting to the setup script. there seems to be some way the forms are automatically generated however I do not seem to be able to reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably don't need to understand how the setup scripts work that much.
The procedure that I would take would be:
* Find a configuration variable that exists in the setup, but not in the user preferences. Let's take $cfg['RecodingEngine'] * grep for it (eg: git grep RecodingEngine) * Look in all files whose names sound like they have something to do with the configuration. * See where the RecodingEngine variable appears in these files * Copy + paste + edit * Check if it works
Hope this helps.
Bye, Rouslan
On Friday, June 14, 2013 at 9:10 PM, Rouslan Placella wrote:
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I read the files in the setup directory however I am not sure how to add my setting to the setup script. there seems to be some way the forms are automatically generated however I do not seem to be able to reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably don't need to understand how the setup scripts work that much.
The procedure that I would take would be:
- Find a configuration variable that exists in the setup, but not in the
user preferences. Let's take $cfg['RecodingEngine']
- grep for it (eg: git grep RecodingEngine)
- Look in all files whose names sound like they have something to do
with the configuration.
- See where the RecodingEngine variable appears in these files
- Copy + paste + edit
- Check if it works
Hope this helps.
Thanks I had already figuered it out. However I am not sure about the difference between the settings in user preferences which use the cookie as storage and the config.inc.php ones since they are both in the $cfg variable. If they share a single variable name who gets preference.
Bye, Rouslan
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On 06/14/2013 09:01 PM, Mohamed Ashraf wrote:
On Friday, June 14, 2013 at 9:10 PM, Rouslan Placella wrote:
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I read the files in the setup directory however I am not sure how to add my setting to the setup script. there seems to be some way the forms are automatically generated however I do not seem to be able to reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably don't need to understand how the setup scripts work that much.
The procedure that I would take would be:
- Find a configuration variable that exists in the setup, but not in the
user preferences. Let's take $cfg['RecodingEngine']
- grep for it (eg: git grep RecodingEngine)
- Look in all files whose names sound like they have something to do
with the configuration.
- See where the RecodingEngine variable appears in these files
- Copy + paste + edit
- Check if it works
Hope this helps.
Thanks I had already figuered it out. However I am not sure about the difference between the settings in user preferences which use the cookie as storage and the config.inc.php ones since they are both in the $cfg variable. If they share a single variable name who gets preference.
User preferences are saved to localStorage or PMA configuration storage, no cookies involved. And AFAIK user preferences can override config.inc.php.
Bye, Rouslan
2013/6/15 Rouslan Placella rouslan@placella.com
On 06/14/2013 09:01 PM, Mohamed Ashraf wrote:
On Friday, June 14, 2013 at 9:10 PM, Rouslan Placella wrote:
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I read the files in the setup directory however I am not sure how to add my setting to the setup script. there seems to be some way the forms are automatically generated however I do not seem to be able to reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably don't need to understand how the setup scripts work that much.
The procedure that I would take would be:
- Find a configuration variable that exists in the setup, but not in the
user preferences. Let's take $cfg['RecodingEngine']
- grep for it (eg: git grep RecodingEngine)
- Look in all files whose names sound like they have something to do
with the configuration.
- See where the RecodingEngine variable appears in these files
- Copy + paste + edit
- Check if it works
Hope this helps.
Thanks I had already figuered it out. However I am not sure about the difference between the settings in user preferences which use the cookie as storage and the config.inc.php ones since they are both in the $cfg variable. If they share a single variable name who gets preference.
User preferences are saved to localStorage or PMA configuration storage, no cookies involved. And AFAIK user preferences can override config.inc.php.
Bye, Rouslan
User preferences are stored in PMA configuration storage or in user session (then they are lost when session expires). They can be backed up and restored from localStorage.
All options available in setup script are defined in setup.forms.php, and all options that can be changed by users are stored in user_preferences.forms.php (unless an option is excluded by UserprefsDisallow array - then users can't change it).
2013/6/15 Piotr Przybylski piotr.prz@gmail.com:
2013/6/15 Rouslan Placella rouslan@placella.com
On 06/14/2013 09:01 PM, Mohamed Ashraf wrote:
On Friday, June 14, 2013 at 9:10 PM, Rouslan Placella wrote:
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I read the files in the setup directory however I am not sure how to add my setting to the setup script. there seems to be some way the forms are automatically generated however I do not seem to be able to reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably don't need to understand how the setup scripts work that much.
The procedure that I would take would be:
- Find a configuration variable that exists in the setup, but not in
the user preferences. Let's take $cfg['RecodingEngine']
- grep for it (eg: git grep RecodingEngine)
- Look in all files whose names sound like they have something to do
with the configuration.
- See where the RecodingEngine variable appears in these files
- Copy + paste + edit
- Check if it works
Hope this helps.
Thanks I had already figuered it out. However I am not sure about the difference between the settings in user preferences which use the cookie as storage and the config.inc.php ones since they are both in the $cfg variable. If they share a single variable name who gets preference.
User preferences are saved to localStorage or PMA configuration storage, no cookies involved. And AFAIK user preferences can override config.inc.php.
Bye, Rouslan
User preferences are stored in PMA configuration storage or in user session (then they are lost when session expires). They can be backed up and restored from localStorage.
All options available in setup script are defined in setup.forms.php, and all options that can be changed by users are stored in user_preferences.forms.php (unless an option is excluded by UserprefsDisallow array - then users can't change it).
Thanks for clarifying this, Piotr. Something like this should be on the wiki. Any volunteers to add it?
-- Kind regards,
Dieter Adriaenssens
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
Yes, that's correct. The new setting should also be documented in the docfile doc/config.rst and be added to the setup script (as Rouslan mentioned).
I will put it in the features/other core options in the setup script unless you have a better place
-
Dieter Adriaenssens -
Mohamed Ashraf -
Piotr Przybylski -
Rouslan Placella