13 Jun
2013
13 Jun
'13
9:51 a.m.
A large subset of phpmyadmin users are not the ones who deployed it.
we need a place to put the settings for error reporting where
unpriviliged users can change them. Is the normal settings page
available for all users or can it be hidden by those offering limited
services such as shared hosting providers. Also in which tab should I
put my settings or should put them in a tab of it own.
13 Jun
13 Jun
7:12 p.m.
On 06/13/2013 08:51 AM, Mohamed Ashraf wrote:
A large subset of phpmyadmin users are not the ones
who deployed it.
we need a place to put the settings for error reporting where
unpriviliged users can change them. Is the normal settings page
available for all users or can it be hidden by those offering limited
services such as shared hosting providers. Also in which tab should I
put my settings or should put them in a tab of it own.
Well, there should be two configuration settings. The first one is
whether the feature is enabled or disabled. I think that this setting
should be only controlled by the administrators of the installation. And
therefore, should not be visible in the user preferences. It should,
however, appear in the setup scripts.
The second settings defines the default action to take when an error is
encountered (values: 'Always Ask', 'Submit Reports Without Asking',
'Never Submit Reports'). I think that the users should be able to
override this setting in the user preferences and when a error prompt
pops up. I also think that this settings should not be shown in the user
preferences if the feature is disabled (a simple if statement somewhere
in the code should accomplish this).
As for the tab, I think that "Feature" -> "General" will be fine.
I'm not sure if I've actually answered your question here, but I hope
this helps anyway...
Bye,
Rouslan
9:09 p.m.
On Thursday, June 13, 2013 at 7:12 PM, Rouslan Placella wrote:
Well, there should be two configuration settings. The
first one is
whether the feature is enabled or disabled. I think that this setting
should be only controlled by the administrators of the installation. And
therefore, should not be visible in the user preferences. It should,
however, appear in the setup scripts.
I think i can include it in the config.php file with the other params such as the enabling
and disabling of the different components such as bookmarks and the sorts.
I'm not sure if I've actually answered your
question here, but I hope
this helps anyway...
No that was great
11 p.m.
On 06/13/2013 08:09 PM, Mohamed Ashraf wrote:
On Thursday, June 13, 2013 at 7:12 PM, Rouslan
Placella wrote:
We don't actually have a config.php file. IIRC, the config settings for
the setup scripts go into libraries/config.*.php files.
Well, there should be two configuration settings.
The first one is
whether the feature is enabled or disabled. I think that this setting
should be only controlled by the administrators of the installation. And
therefore, should not be visible in the user preferences. It should,
however, appear in the setup scripts.
I think i can include it in the config.php
file with the other params
such as the enabling and disabling of the different components such as
bookmarks and the sorts. I'm not
sure if I've actually answered your question here, but I hope
this helps anyway...
No that was great
14 Jun
14 Jun
12:07 a.m.
On Thursday, June 13, 2013 at 11:00 PM, Rouslan Placella wrote:
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On 06/13/2013 08:09 PM, Mohamed Ashraf wrote:
I put them in config.sample.inc.php and libraries/config.default.php
On Thursday, June 13, 2013 at 7:12 PM, Rouslan
Placella wrote:
We don't actually have a config.php file. IIRC, the config settings for
the setup scripts go into libraries/config.*.php files.
Well, there should be two configuration settings.
The first one is
whether the feature is enabled or disabled. I think that this setting
should be only controlled by the administrators of the installation. And
therefore, should not be visible in the user preferences. It should,
however, appear in the setup scripts.
I think i can include it in the config.php file with the other params
such as the enabling and disabling of the different components such as
bookmarks and the sorts.
I'm
not sure if I've actually answered your question here, but I hope
this helps anyway...
No that was great
10:33 a.m.
2013/6/14 Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com>om>:
On Thursday, June 13, 2013 at 11:00 PM, Rouslan
Placella wrote:
On 06/13/2013 08:09 PM, Mohamed Ashraf wrote:
On Thursday, June 13, 2013 at 7:12 PM, Rouslan Placella wrote:
Well, there should be two configuration settings. The first one is
whether the feature is enabled or disabled. I think that this setting
should be only controlled by the administrators of the installation. And
therefore, should not be visible in the user preferences. It should,
however, appear in the setup scripts.
I think i can include it in the config.php file with the other params
such as the enabling and disabling of the different components such as
bookmarks and the sorts.
We don't actually have a config.php file. IIRC, the config settings for
the setup scripts go into libraries/config.*.php files.
I put them in config.sample.inc.php and libraries/config.default.php
Yes, that's correct.
The new setting should also be documented in the docfile
doc/config.rst and be added to the setup script (as Rouslan
mentioned).
I'm not sure if I've actually answered your question here, but I hope
this helps anyway...
No that was great
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
--
Kind regards,
Dieter Adriaenssens
11:44 a.m.
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens
<dieter.adriaenssens(a)gmail.com> wrote:
Yes, that's correct.
The new setting should also be documented in the docfile
doc/config.rst and be added to the setup script (as Rouslan
mentioned).
I read the files in the setup directory however I am not sure how to
add my setting to the setup script. there seems to be some way the
forms are automatically generated however I do not seem to be able to
reverse engineer it.
9:10 p.m.
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens
<dieter.adriaenssens(a)gmail.com> wrote:
You don't need to reverse engineer anything. In fact, you probably don't
need to understand how the setup scripts work that much.
The procedure that I would take would be:
* Find a configuration variable that exists in the setup, but not in the
user preferences. Let's take $cfg['RecodingEngine']
* grep for it (eg: git grep RecodingEngine)
* Look in all files whose names sound like they have something to do
with the configuration.
* See where the RecodingEngine variable appears in these files
* Copy + paste + edit
* Check if it works
Hope this helps.
Bye,
Rouslan
Yes, that's correct.
The new setting should also be documented in the docfile
doc/config.rst and be added to the setup script (as Rouslan
mentioned).
I read the files in the setup directory however I am not sure how to
add my setting to the setup script. there seems to be some way the
forms are automatically generated however I do not seem to be able to
reverse engineer it.
10:01 p.m.
On Friday, June 14, 2013 at 9:10 PM, Rouslan Placella wrote:
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
Thanks I had already figuered it out. However I am not sure about the difference
between the settings in user preferences which use the cookie as storage and the
config.inc.php ones since they are both in the $cfg variable. If they share a single
variable name who gets preference.
On Fri, Jun 14, 2013 at 10:33 AM, Dieter
Adriaenssens
<dieter.adriaenssens(a)gmail.com> wrote:
You don't need to reverse engineer anything. In fact, you probably don't
need to understand how the setup scripts work that much.
The procedure that I would take would be:
* Find a configuration variable that exists in the setup, but not in the
user preferences. Let's take $cfg['RecodingEngine']
* grep for it (eg: git grep RecodingEngine)
* Look in all files whose names sound like they have something to do
with the configuration.
* See where the RecodingEngine variable appears in these files
* Copy + paste + edit
* Check if it works
Hope this helps.
Yes, that's correct.
The new setting should also be documented in the docfile
doc/config.rst and be added to the setup script (as Rouslan
mentioned).
I read the files in the setup directory however I am not sure how to
add my setting to the setup script. there seems to be some way the
forms are automatically generated however I do not seem to be able to
reverse engineer it.
Bye,
Rouslan
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
15 Jun
15 Jun
8:57 a.m.
On 06/14/2013 09:01 PM, Mohamed Ashraf wrote:
On Friday, June 14, 2013 at 9:10 PM, Rouslan Placella
wrote:
User preferences are saved to localStorage or PMA configuration storage,
no cookies involved. And AFAIK user preferences can override config.inc.php.
Bye,
Rouslan
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
Thanks I had already figuered it out. However I am not sure about the
difference between the settings in user preferences which use the cookie
as storage and the config.inc.php ones since they are both in the $cfg
variable. If they share a single variable name who gets preference. On Fri, Jun 14, 2013 at 10:33 AM, Dieter
Adriaenssens
<dieter.adriaenssens(a)gmail.com> wrote:
You don't need to reverse engineer anything. In fact, you probably don't
need to understand how the setup scripts work that much.
The procedure that I would take would be:
* Find a configuration variable that exists in the setup, but not in the
user preferences. Let's take $cfg['RecodingEngine']
* grep for it (eg: git grep RecodingEngine)
* Look in all files whose names sound like they have something to do
with the configuration.
* See where the RecodingEngine variable appears in these files
* Copy + paste + edit
* Check if it works
Hope this helps.
Yes, that's correct.
The new setting should also be documented in the docfile
doc/config.rst and be added to the setup script (as Rouslan
mentioned).
I read the files in the setup directory however I am not sure how to
add my setting to the setup script. there seems to be some way the
forms are automatically generated however I do not seem to be able to
reverse engineer it. 
4:01 p.m.
2013/6/15 Rouslan Placella <rouslan(a)placella.com>
On 06/14/2013 09:01 PM, Mohamed Ashraf wrote:
User preferences are stored in PMA configuration storage or in user session
(then they are lost when session expires). They can be backed up and
restored from localStorage.
All options available in setup script are defined in setup.forms.php, and
all options that can be changed by users are stored in
user_preferences.forms.php (unless an option is excluded by
UserprefsDisallow array - then users can't change it).
--
Regards,
Piotr Przybylski
On Friday, June 14, 2013 at 9:10 PM, Rouslan
Placella wrote:
User preferences are saved to localStorage or PMA configuration storage,
no cookies involved. And AFAIK user preferences can override
config.inc.php.
Bye,
Rouslan
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
Thanks I had already figuered it out. However I am not sure about the
difference between the settings in user preferences which use the cookie
as storage and the config.inc.php ones since they are both in the $cfg
variable. If they share a single variable name who gets preference. On Fri, Jun 14, 2013 at 10:33 AM, Dieter
Adriaenssens
<dieter.adriaenssens(a)gmail.com> wrote:
> Yes, that's correct.
> The new setting should also be documented in the docfile
> doc/config.rst and be added to the setup script (as Rouslan
> mentioned).
I read the files in the setup directory however I am not sure how to
add my setting to the setup script. there seems to be some way the
forms are automatically generated however I do not seem to be able to
reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably don't
need to understand how the setup scripts work that much.
The procedure that I would take would be:
* Find a configuration variable that exists in the setup, but not in the
user preferences. Let's take $cfg['RecodingEngine']
* grep for it (eg: git grep RecodingEngine)
* Look in all files whose names sound like they have something to do
with the configuration.
* See where the RecodingEngine variable appears in these files
* Copy + paste + edit
* Check if it works
Hope this helps.
16 Jun
16 Jun
12:08 p.m.
2013/6/15 Piotr Przybylski <piotr.prz(a)gmail.com>om>:
2013/6/15 Rouslan Placella
<rouslan(a)placella.com>
Thanks for clarifying this, Piotr.
Something like this should be on the wiki. Any volunteers to add it?
--
Kind regards,
Dieter Adriaenssens
On 06/14/2013 09:01 PM, Mohamed Ashraf wrote:
User preferences are stored in PMA configuration storage or in user session
(then they are lost when session expires). They can be backed up and
restored from localStorage.
All options available in setup script are defined in setup.forms.php, and
all options that can be changed by users are stored in
user_preferences.forms.php (unless an option is excluded by
UserprefsDisallow array - then users can't change it). On Friday, June 14, 2013 at 9:10 PM, Rouslan
Placella wrote:
User preferences are saved to localStorage or PMA configuration storage,
no cookies involved. And AFAIK user preferences can override
config.inc.php.
Bye,
Rouslan
On 06/14/2013 10:44 AM, Mohamed Ashraf wrote:
> On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens
> <dieter.adriaenssens(a)gmail.com> wrote:
>> Yes, that's correct.
>> The new setting should also be documented in the docfile
>> doc/config.rst and be added to the setup script (as Rouslan
>> mentioned).
>
> I read the files in the setup directory however I am not sure how to
> add my setting to the setup script. there seems to be some way the
> forms are automatically generated however I do not seem to be able to
> reverse engineer it.
You don't need to reverse engineer anything. In fact, you probably
don't
need to understand how the setup scripts work that much.
The procedure that I would take would be:
* Find a configuration variable that exists in the setup, but not in
the
user preferences. Let's take $cfg['RecodingEngine']
* grep for it (eg: git grep RecodingEngine)
* Look in all files whose names sound like they have something to do
with the configuration.
* See where the RecodingEngine variable appears in these files
* Copy + paste + edit
* Check if it works
Hope this helps.
Thanks I had already figuered it out. However I am not sure about the
difference between the settings in user preferences which use the cookie
as storage and the config.inc.php ones since they are both in the $cfg
variable. If they share a single variable name who gets preference.
14 Jun
14 Jun
5:33 p.m.
On Fri, Jun 14, 2013 at 10:33 AM, Dieter Adriaenssens
<dieter.adriaenssens(a)gmail.com> wrote:
Yes, that's correct.
The new setting should also be documented in the docfile
doc/config.rst and be added to the setup script (as Rouslan
mentioned).
I will put it in the features/other core options in the setup script
unless you have a better place
4119
days inactive
4122
days old
12 comments
4 participants
participants (4)
-
Dieter Adriaenssens -
Mohamed Ashraf -
Piotr Przybylski -
Rouslan Placella