[Phpmyadmin-devel] I am back
Dear Everyone, I am back now, after a few time of calls. First I must apologize for having abadon my duty as a team member. I have switched job from a (sort of) programmer to a lecturer at a new university. I will start giving my first lecture "Calculus I" next month and after a few months (or years ^_^), I may have some of my students coding in an open source project as a homework. Not sure if this is a valid excuse anyway. :) Enough about me. It is to my surprise to see the project progress so much. I need to spend some time to study the code again. So much features, but still one on the top of the list "Function depend on Type" suggested by me is left undone. So I start with this one. The change has worked on my computer. But I need to modify the structure of 2 config vars $cfg['ColumnTypes'], $cfg['Functions'] from simple array to associative array. Like this $cfg['ColumnTypes'] = array( 'VARCHAR', 'TINYINT', 'TEXT', ... to $cfg['ColumnTypes'] = array( 'VARCHAR'=>'str', 'TINYINT'=>'int', 'TEXT'=>'str', ... and match the two config and check before display the function in the dropdown box. A problem is that, after search for the two config vars, I also found it inside /library/config_import.lib.php3 Can someone please explain the concept of it? I guess I can simply change the structure of the two vars there. But I am afraid that in won't work in case of import old config file. Thanks, Korakot
Korakot Chaovavanich wrote:
Dear Everyone,
I am back now, after a few time of calls. First I must apologize for having abadon my duty as a team member. I have switched job from a (sort of) programmer to a lecturer at a new university. I will start giving my first lecture "Calculus I" next month and after a few months (or years ^_^), I may have some of my students coding in an open source project as a homework. Not sure if this is a valid excuse anyway. :)
Welcome back :)
Enough about me. It is to my surprise to see the project progress so much. I need to spend some time to study the code again. So much features, but still one on the top of the list "Function depend on Type" suggested by me is left undone.
So I start with this one. The change has worked on my computer. But I need to modify the structure of 2 config vars $cfg['ColumnTypes'], $cfg['Functions'] from simple array to associative array. Like this
$cfg['ColumnTypes'] = array( 'VARCHAR', 'TINYINT', 'TEXT', ... to $cfg['ColumnTypes'] = array( 'VARCHAR'=>'str', 'TINYINT'=>'int', 'TEXT'=>'str', ... and match the two config and check before display the function in the dropdown box.
A problem is that, after search for the two config vars, I also found it inside /library/config_import.lib.php3 Can someone please explain the concept of it?
This script is used when we detect an old config file. So I guess you just have to put the new definition of $cfg['ColumnTypes'] in config_import.lib.php3 also.
I guess I can simply change the structure of the two vars there. But I am afraid that in won't work in case of import old config file.
Thanks, Korakot
------------------------------------------------------- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle
----- Original Message ----- From: "Marc Delisle" <Delislma@CollegeSherbrooke.qc.ca>
A problem is that, after search for the two config vars, I also found it inside /library/config_import.lib.php3 Can someone please explain the concept of it?
This script is used when we detect an old config file. So I guess you just have to put the new definition of $cfg['ColumnTypes'] in config_import.lib.php3 also.
No, it's a bit more complicated: He also needs to insert some code here that is able to detect the old format of the arrays and convert it into the new one. Regards, Alexander
Rabus wrote:
----- Original Message ----- From: "Marc Delisle" <Delislma@CollegeSherbrooke.qc.ca>
A problem is that, after search for the two config vars, I also found it inside /library/config_import.lib.php3 Can someone please explain the concept of it?
This script is used when we detect an old config file. So I guess you just have to put the new definition of $cfg['ColumnTypes'] in config_import.lib.php3 also.
No, it's a bit more complicated: He also needs to insert some code here that is able to detect the old format of the arrays and convert it into the new one.
I don't understand why: those are not configurable by the user... -- Marc Delisle
On Tue, Aug 27, 2002 at 04:02:59PM -0400, Marc Delisle wrote:
This script is used when we detect an old config file. So I guess you just have to put the new definition of $cfg['ColumnTypes'] in config_import.lib.php3 also. No, it's a bit more complicated: He also needs to insert some code here that is able to detect the old format of the arrays and convert it into the new one. I don't understand why: those are not configurable by the user...
I agree. Lets actually take $cfg['ColumnTypes'], $cfg['AttributeTypes'], $cfg['Functions'] out of $cfg, and keep it somewhere else instead. No user should ever be changing these, so that confirms for me that we can move them. That will also open them up to working better with MySQL 4, as that introduces a number of new functions I am told. if(MYSQL_INT_VER > 40000) { $dataFunctions['MYSQL4FUNC'] => 'str'; } -- Robin Hugh Johnson E-Mail : robbat2@orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
----- Original Message ----- From: "Marc Delisle" <Delislma@CollegeSherbrooke.qc.ca>
Rabus wrote:
----- Original Message ----- From: "Marc Delisle" <Delislma@CollegeSherbrooke.qc.ca>
A problem is that, after search for the two config vars, I also found it inside /library/config_import.lib.php3 Can someone please explain the concept of it?
This script is used when we detect an old config file. So I guess you just have to put the new definition of $cfg['ColumnTypes'] in config_import.lib.php3 also.
No, it's a bit more complicated: He also needs to insert some code here that is able to detect the old
format
of the arrays and convert it into the new one.
I don't understand why: those are not configurable by the user...
Hmm, you're right. Let's remove them from config.inc.php3, then. imho we shut put them into an extra library. (btw, who has removed Korakot from the developers list at SF? :o) ) Alexander
participants (4)
-
Korakot Chaovavanich -
Marc Delisle -
Rabus -
Robin Johnson