Hi Lo$B}D(B, Lo$B}D(B wrote:

I'm currently working on your patch: I'm aplying our coding standards to it. Could you please complete the attached library (see the "?" inside).

It's your beautiful aplying :-)

Just two notes : - could you please add an e-mail addess near the author name?

I added my working e-mail address.

- at the beginning of "PMA_kanji_str_conv" you put a "global" statement for "$internal_enc" but this variable isn't used inside the function!

Yes, you are correct. No need variable $internal_enc in this function. Thank you.