[Phpmyadmin-devel] Charts colors and git question
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key. After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong? Thanks in advance.
On Sat, 2011-04-30 at 15:27 +0200, Tyron Madlener wrote:
I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key. After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong?
Thanks in advance.
I can't exactly understand your explanation of the problem, but you should pull via 'http' or 'git' protocols and push via 'ssh'. Maybe that's it? Rouslan
On 30-04-11 15:27, Tyron Madlener wrote:
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Nice improvement to start your project with :)
I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key. After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong?
So you first cloned the phpmyadmin repository from |git://phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin After that the git remote add ... should be correct. You might try 'git fetch tyronm' to get data from your repo. I'm not really familiar with repo.or.cz but if the repo there is completely empty you might have to push a branch to it. 'git push tyronm master' | -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions
Hello, On 1 Mei 2011, at 19:29, Herman van Rink <rink@initfour.nl> wrote:
On 30-04-11 15:27, Tyron Madlener wrote:
I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key. After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong? Can you give some screenshot of the output when you try to pull from your repo?
So you first cloned the phpmyadmin repository from git://phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin After that the git remote add ... should be correct.
You might try 'git fetch tyronm' to get data from your repo. I'm not really familiar with repo.or.cz but if the repo there is completely empty you might have to push a branch to it. 'git push tyronm master'
-- Met vriendelijke groet / Regards,
Herman van Rink Initfour websolutions
Hi Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key.
If it asks for user name and password, something is wrong, it should use only they key.
After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong?
pull is to download from remote tree, while push is to publish changes back. Maybe that is actually the problem? -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Mon, May 2, 2011 at 11:23 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
Shall I upload the patch to the sourceforge tracker?
I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key.
If it asks for user name and password, something is wrong, it should use only they key.
After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong?
pull is to download from remote tree, while push is to publish changes back. Maybe that is actually the problem?
Oh, only now I realize I've replied to the wrong address. I've got it working already. Here's what I did yesterday: It seems like i narrowed it down to the fact that ssh seems to take my default username that is 'Tyron' instead of the username provided in the git config, that is 'tyron' E:\htdocs\phpmyadmin>git push tyronm Tyron@repo.or.cz's password: When I supply ssh with the right username it seems to work: E:\htdocs\phpmyadmin>ssh -l tyron repo.or.cz Enter passphrase for key '/home/Tyron/.ssh/id_rsa': fatal: What do you think I am? A shell? Connection to repo.or.cz closed. Oh well. I just signed up another user named Tyron on repo.or.cz. Now it works. Thanks anyway :)
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
W dniu 2 maja 2011 15:35 użytkownik Tyron Madlener <tyronx@gmail.com> napisał:
On Mon, May 2, 2011 at 11:23 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
Shall I upload the patch to the sourceforge tracker?
I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key.
If it asks for user name and password, something is wrong, it should use only they key.
After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong?
pull is to download from remote tree, while push is to publish changes back. Maybe that is actually the problem?
Oh, only now I realize I've replied to the wrong address. I've got it working already. Here's what I did yesterday:
It seems like i narrowed it down to the fact that ssh seems to take my default username that is 'Tyron' instead of the username provided in the git config, that is 'tyron'
E:\htdocs\phpmyadmin>git push tyronm Tyron@repo.or.cz's password:
When I supply ssh with the right username it seems to work:
E:\htdocs\phpmyadmin>ssh -l tyron repo.or.cz Enter passphrase for key '/home/Tyron/.ssh/id_rsa': fatal: What do you think I am? A shell? Connection to repo.or.cz closed.
Oh well. I just signed up another user named Tyron on repo.or.cz. Now it works. Thanks anyway :)
You could have overridden your login by editing ~/.ssh/config and adding: Host repo.or.cs User username ;) -- Regards, Piotr Przybylski
Oh, ok. Thanks for the info! 2011/5/2 Piotr Przybylski <piotr.prz@gmail.com>:
W dniu 2 maja 2011 15:35 użytkownik Tyron Madlener <tyronx@gmail.com> napisał:
On Mon, May 2, 2011 at 11:23 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
Shall I upload the patch to the sourceforge tracker?
I tried to pull it to my repos on repo.or.cz but it doesn't accept my user name and password. Set I set up a push account for me though, and typed in my public key. The (Windows)-git-commit-tool-gui shows me the same public key.
If it asks for user name and password, something is wrong, it should use only they key.
After I checked out the code, I've added my repos with the command 'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git' then trying to pull via 'git pull tyronm'. Anyone know what I'm doing wrong?
pull is to download from remote tree, while push is to publish changes back. Maybe that is actually the problem?
Oh, only now I realize I've replied to the wrong address. I've got it working already. Here's what I did yesterday:
It seems like i narrowed it down to the fact that ssh seems to take my default username that is 'Tyron' instead of the username provided in the git config, that is 'tyron'
E:\htdocs\phpmyadmin>git push tyronm Tyron@repo.or.cz's password:
When I supply ssh with the right username it seems to work:
E:\htdocs\phpmyadmin>ssh -l tyron repo.or.cz Enter passphrase for key '/home/Tyron/.ssh/id_rsa': fatal: What do you think I am? A shell? Connection to repo.or.cz closed.
Oh well. I just signed up another user named Tyron on repo.or.cz. Now it works. Thanks anyway :)
You could have overridden your login by editing ~/.ssh/config and adding: Host repo.or.cs User username
;)
-- Regards, Piotr Przybylski
Hi Dne Mon, 2 May 2011 15:35:36 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Mon, May 2, 2011 at 11:23 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
Shall I upload the patch to the sourceforge tracker?
Yes please, either directly or just reference commit id in your branch. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Tue, May 3, 2011 at 11:30 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Mon, 2 May 2011 15:35:36 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Mon, May 2, 2011 at 11:23 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
Shall I upload the patch to the sourceforge tracker?
Yes please, either directly or just reference commit id in your branch.
Okay, that should be commit id 7645bc93d1aa43ad4092e332f914b9362ace1f01 in my branch.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Tue, 3 May 2011 13:26:07 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Tue, May 3, 2011 at 11:30 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Mon, 2 May 2011 15:35:36 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Mon, May 2, 2011 at 11:23 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
Shall I upload the patch to the sourceforge tracker?
Yes please, either directly or just reference commit id in your branch.
Okay, that should be commit id 7645bc93d1aa43ad4092e332f914b9362ace1f01 in my branch.
Please keep coding style, you seem to change indentation in the new code. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
2011/5/5 Michal Čihař <michal@cihar.com>:
Hi
Dne Tue, 3 May 2011 13:26:07 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Tue, May 3, 2011 at 11:30 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Mon, 2 May 2011 15:35:36 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Mon, May 2, 2011 at 11:23 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Sat, 30 Apr 2011 15:27:47 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
I thought its a good idea to make the charts adjust to the current theme colors, so I wrote a patch for it: http://www.tyron.at/tmp/chart_colors.patch I also wrote a short blog entry about it, showing screenshots of the new changed charts: http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
Changed colors definitely look better.
Shall I upload the patch to the sourceforge tracker?
Yes please, either directly or just reference commit id in your branch.
Okay, that should be commit id 7645bc93d1aa43ad4092e332f914b9362ace1f01 in my branch.
Please keep coding style, you seem to change indentation in the new code.
Ah yes sorry. I'm used to have 4-space-tabs. I fixed it with commit 246cf649e472779a8fb8df81710cbd9fb2e2bffc
-- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
Hi Dne Thu, 5 May 2011 10:17:17 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
Ah yes sorry. I'm used to have 4-space-tabs. I fixed it with commit 246cf649e472779a8fb8df81710cbd9fb2e2bffc
See http://wiki.phpmyadmin.net/pma/Coding_guidelines for more information about coding standards. Thanks for the fix, I've merged the patch. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
participants (6)
-
Aris Feryanto -
Herman van Rink -
Michal Čihař -
Piotr Przybylski -
Rouslan Placella -
Tyron Madlener