Re: [Phpmyadmin-devel] Interested in GSOC project--Server variables and settings page help - ID: 3196075
Hi,
I have committed my work for Server variables and settings page help - ID: 3196075. I modified server_variables.php and store the information in the table pma_server_variables whose sql file in the folder script. you should import the table first.
Please check it on http://repo.or.cz/r/phpmyadmin/dennischen.git/
I use qtip to show the description but it seems that qtip confilcts with the functon which toggle the hover class, but I cannot find where is the function, can somebody help me ?
Another suggestion, JQueryUI 1.9 will include a tooltip layout, maybe we can use that instead of qtip?It's hard to say when 1.9 will be released though
Dennis Chen
2011/3/11 Marc Delisle marc@infomarc.info
harsh gidra a écrit :
Hi,
I think one needs to have a *sourceforge.net http://sourceforge.net* account before executing the above mentioned command. That would suffice.
No, this command is only for members of the project. But the wiki page http://wiki.phpmyadmin.net/pma/Git gives another command to clone the repository with read-only access (typed on one line)
git clone git:// phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin
The other reference I gave would be useful in case someone wants to publish his repository, which is what is expected for GSoC students.
2011/3/11 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>
陈岳峰 a écrit : > Hi, > > Sorry to bother you again. > > When I followed the git instruction on the git and input thecommand:
> > git clone ssh://USERNAME@phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin
<http://USERNAME@phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin>
<http://USERNAME@phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin
<http://phpmyadmin.git.sourceforge.net/gitroot/phpmyadmin/phpmyadmin# Write access > > I was asked to input the password, so does that mean I need to create > an account somewhere? It means you are not part of the phpMyAdmin development team. Look on this wiki page for "If you are not (yet) a team member". -- Marc Delisle http://infomarc.info-- Marc Delisle http://infomarc.info
Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
陈岳峰 a écrit :
Hi,
I have committed my work for Server variables and settings page help - ID: 3196075. I modified server_variables.php and store the information in the table pma_server_variables whose sql file in the folder script. you should import the table first.
Please check it on http://repo.or.cz/r/phpmyadmin/dennischen.git/ Dennis Chen
Dennis, did you push your changes to the remote repo? I fetched it and there are no changes.
Hi,
I can see the log
commit f337248acce77a4ea3c13c96fffa813f218cf5e3 Author: dennischen dennislyve@gmail.com Date: Mon Mar 14 14:16:17 2011 +0800
for Server_variables
commit f1ac81605e230c3d2c81e883499fcef42e2c4b57 Author: dennischen dennislyve@gmail.com Date: Mon Mar 14 14:11:09 2011 +0800
Server Variables--ID: 3196075
do I commit the code to the official repo or somewhere else?
On Tue, Mar 15, 2011 at 12:45 AM, Marc Delisle marc@infomarc.info wrote:
陈岳峰 a écrit :
Hi,
I have committed my work for Server variables and settings page help - ID: 3196075. I modified server_variables.php and store the information in the table pma_server_variables whose sql file in the folder script. you should import the table first.
Please check it on http://repo.or.cz/r/phpmyadmin/dennischen.git/ Dennis Chen
Dennis, did you push your changes to the remote repo? I fetched it and there are no changes.
-- Marc Delisle http://infomarc.info
Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi,
I commit it again, I don't know whether it works.
Dennis Chen
On Tue, Mar 15, 2011 at 10:08 AM, 陈岳峰 dennislyve@gmail.com wrote:
Hi,
I can see the log
commit f337248acce77a4ea3c13c96fffa813f218cf5e3 Author: dennischen dennislyve@gmail.com Date: Mon Mar 14 14:16:17 2011 +0800
for Server_variablescommit f1ac81605e230c3d2c81e883499fcef42e2c4b57 Author: dennischen dennislyve@gmail.com Date: Mon Mar 14 14:11:09 2011 +0800
Server Variables--ID: 3196075do I commit the code to the official repo or somewhere else?
On Tue, Mar 15, 2011 at 12:45 AM, Marc Delisle marc@infomarc.info wrote:
陈岳峰 a écrit :
Hi,
I have committed my work for Server variables and settings page help - ID: 3196075. I modified server_variables.php and store the information in the table pma_server_variables whose sql file in the folder script. you should import the table first.
Please check it on http://repo.or.cz/r/phpmyadmin/dennischen.git/ Dennis Chen
Dennis, did you push your changes to the remote repo? I fetched it and there are no changes.
-- Marc Delisle http://infomarc.info
Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
陈岳峰 a écrit :
Hi,
I can see the log
commit f337248acce77a4ea3c13c96fffa813f218cf5e3 Author: dennischen <dennislyve@gmail.com mailto:dennislyve@gmail.com> Date: Mon Mar 14 14:16:17 2011 +0800
for Server_variablescommit f1ac81605e230c3d2c81e883499fcef42e2c4b57 Author: dennischen <dennislyve@gmail.com mailto:dennislyve@gmail.com> Date: Mon Mar 14 14:11:09 2011 +0800
Server Variables--ID: 3196075do I commit the code to the official repo or somewhere else?
First, in this mailing list, please do not top-post, it's difficult to read.
Second, about your question. I did not say that you did not commit, I said that you did not push. Seeing the commit lines in the log means that you committed to your local repo, but unless you push to the remote repo, we cannot see your work.
Today I see that you have pushed to the remote repo so we'll be able to look at your work.
Dennis, did you push your changes to the remote repo? I fetched it and there are no changes. -- Marc Delisle http://infomarc.info
Marc Delisle a écrit :
陈岳峰 a écrit :
Hi,
I can see the log
commit f337248acce77a4ea3c13c96fffa813f218cf5e3 Author: dennischen <dennislyve@gmail.com mailto:dennislyve@gmail.com> Date: Mon Mar 14 14:16:17 2011 +0800
for Server_variablescommit f1ac81605e230c3d2c81e883499fcef42e2c4b57 Author: dennischen <dennislyve@gmail.com mailto:dennislyve@gmail.com> Date: Mon Mar 14 14:11:09 2011 +0800
Server Variables--ID: 3196075do I commit the code to the official repo or somewhere else?
First, in this mailing list, please do not top-post, it's difficult to read.
Second, about your question. I did not say that you did not commit, I said that you did not push. Seeing the commit lines in the log means that you committed to your local repo, but unless you push to the remote repo, we cannot see your work.
Today I see that you have pushed to the remote repo so we'll be able to look at your work.
Your patch works correctly, if I use commit f337248acce77a4ea3c13c96fffa813f218cf5e3.
Beware that later in commit 4e39b62a2a00a5a624dfae5874a85a88a398edd8 you _reverted_ a commit so your latest repository does not contains the changes that make each variable clickable and shows the tooltip.
-
Marc Delisle -
陈岳峰