[Phpmyadmin-devel] Proposal: Refactoring Designer/schema integration
hello Michal, I have submitted my proposal, please have a look at it. Give your important input So I could edit my proposal then. Thanks -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
On Tue, Apr 3, 2012 at 9:15 PM, Adnan <hiddenpearls@gmail.com> wrote:
hello Michal,
I have submitted my proposal, please have a look at it. Give your important input So I could edit my proposal then. Thanks
Any input please ?
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
Op 4 april 2012 11:07 heeft Adnan <hiddenpearls@gmail.com> het volgende geschreven:
On Tue, Apr 3, 2012 at 9:15 PM, Adnan <hiddenpearls@gmail.com> wrote:
hello Michal,
I have submitted my proposal, please have a look at it. Give your important input So I could edit my proposal then. Thanks
Any input please ?
You proposal will be reviewed by the mentors in due time. Your proposal is not the only one to be reviewed, so please be patient. -- Kind regards, Dieter Adriaenssens
On Fri, Apr 6, 2012 at 9:35 PM, Dieter Adriaenssens < dieter.adriaenssens@gmail.com> wrote:
Op 4 april 2012 11:07 heeft Adnan <hiddenpearls@gmail.com> het volgende geschreven:
On Tue, Apr 3, 2012 at 9:15 PM, Adnan <hiddenpearls@gmail.com> wrote:
hello Michal,
I have submitted my proposal, please have a look at it. Give your important input So I could edit my proposal then. Thanks
Any input please ?
You proposal will be reviewed by the mentors in due time. Your proposal is not the only one to be reviewed, so please be patient.
Thanks, I got it.
-- Kind regards,
Dieter Adriaenssens
------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
On Fri, Apr 6, 2012 at 9:37 PM, Adnan <hiddenpearls@gmail.com> wrote:
On Fri, Apr 6, 2012 at 9:35 PM, Dieter Adriaenssens < dieter.adriaenssens@gmail.com> wrote:
Op 4 april 2012 11:07 heeft Adnan <hiddenpearls@gmail.com> het volgende geschreven:
On Tue, Apr 3, 2012 at 9:15 PM, Adnan <hiddenpearls@gmail.com> wrote:
hello Michal,
I have submitted my proposal, please have a look at it. Give your important input So I could edit my proposal then. Thanks
Any input please ?
You proposal will be reviewed by the mentors in due time. Your proposal is not the only one to be reviewed, so please be patient.
Thanks, I got it.
I wanted to discuss about the bad design patterns used in schema generation classes. According to my knowledge, 1. In Class PMA_Schema_PDF and other schema classes, properties are used with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties like var was standard in php4. So, in php5 standards are to use public,protected or private keywords. Though after 5.1.3 var is not deprecated and doesn't issue E_STRICT warning. so var used in current code is considered as public. Best pattren is to use protected keyword for properties in Schema classes. 2. Singleton/factory pattern is not used in schema classes. I guess, we should use it instead of instantiating objects on running scripts.
--
Kind regards,
Dieter Adriaenssens
------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
On Sat, Apr 7, 2012 at 2:02 PM, Adnan <hiddenpearls@gmail.com> wrote:
On Fri, Apr 6, 2012 at 9:37 PM, Adnan <hiddenpearls@gmail.com> wrote:
On Fri, Apr 6, 2012 at 9:35 PM, Dieter Adriaenssens < dieter.adriaenssens@gmail.com> wrote:
Op 4 april 2012 11:07 heeft Adnan <hiddenpearls@gmail.com> het volgende geschreven:
On Tue, Apr 3, 2012 at 9:15 PM, Adnan <hiddenpearls@gmail.com> wrote:
hello Michal,
I have submitted my proposal, please have a look at it. Give your important input So I could edit my proposal then. Thanks
Any input please ?
You proposal will be reviewed by the mentors in due time. Your proposal is not the only one to be reviewed, so please be patient.
Thanks, I got it.
I wanted to discuss about the bad design patterns used in schema generation classes. According to my knowledge,
1. In Class PMA_Schema_PDF and other schema classes, properties are used with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties like var was standard in php4. So, in php5 standards are to use public,protected or private keywords. Though after 5.1.3 var is not deprecated and doesn't issue E_STRICT warning. so var used in current code is considered as public. Best pattren is to use protected keyword for properties in Schema classes.
2. Singleton/factory pattern is not used in schema classes. I guess, we should use it instead of instantiating objects on running scripts.
any input on this please ?
--
Kind regards,
Dieter Adriaenssens
------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
Hi Dne Mon, 9 Apr 2012 15:51:59 +0500 Adnan <hiddenpearls@gmail.com> napsal(a):
On Sat, Apr 7, 2012 at 2:02 PM, Adnan <hiddenpearls@gmail.com> wrote:
I wanted to discuss about the bad design patterns used in schema generation classes. According to my knowledge,
1. In Class PMA_Schema_PDF and other schema classes, properties are used with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties like var was standard in php4. So, in php5 standards are to use public,protected or private keywords. Though after 5.1.3 var is not deprecated and doesn't issue E_STRICT warning. so var used in current code is considered as public. Best pattren is to use protected keyword for properties in Schema classes.
2. Singleton/factory pattern is not used in schema classes. I guess, we should use it instead of instantiating objects on running scripts.
any input on this please ?
Yes, you have input at the proposal. Please try to avoid spreading same topic over several channels. Also do not expect everybody is online and has time 24/7 - people are away from computers sometimes. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Tue, Apr 10, 2012 at 4:56 PM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Mon, 9 Apr 2012 15:51:59 +0500 Adnan <hiddenpearls@gmail.com> napsal(a):
On Sat, Apr 7, 2012 at 2:02 PM, Adnan <hiddenpearls@gmail.com> wrote:
I wanted to discuss about the bad design patterns used in schema generation classes. According to my knowledge,
1. In Class PMA_Schema_PDF and other schema classes, properties are used with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties like var was standard in php4. So, in php5 standards are to use public,protected or private keywords. Though after 5.1.3 var is not deprecated and doesn't issue E_STRICT warning. so var used in current code is considered as public. Best pattren is to use protected keyword for properties in Schema classes.
2. Singleton/factory pattern is not used in schema classes. I guess, we should use it instead of instantiating objects on running scripts.
any input on this please ?
Yes, you have input at the proposal. Please try to avoid spreading same topic over several channels. Also do not expect everybody is online and has time 24/7 - people are away from computers sometimes.
Thanks for input. Sorry, It will never happen again.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
On Tue, Apr 10, 2012 at 5:46 PM, Adnan <hiddenpearls@gmail.com> wrote:
On Tue, Apr 10, 2012 at 4:56 PM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Mon, 9 Apr 2012 15:51:59 +0500 Adnan <hiddenpearls@gmail.com> napsal(a):
On Sat, Apr 7, 2012 at 2:02 PM, Adnan <hiddenpearls@gmail.com> wrote:
I wanted to discuss about the bad design patterns used in schema generation classes. According to my knowledge,
1. In Class PMA_Schema_PDF and other schema classes, properties are used with var which is deprecated from PHP 5.0 to 5.1.3 as declaring properties like var was standard in php4. So, in php5 standards are to use public,protected or private keywords. Though after 5.1.3 var is not deprecated and doesn't issue E_STRICT warning. so var used in current code is considered as public. Best pattren is to use protected keyword for properties in Schema classes.
2. Singleton/factory pattern is not used in schema classes. I guess, we should use it instead of instantiating objects on running scripts.
any input on this please ?
Yes, you have input at the proposal. Please try to avoid spreading same topic over several channels. Also do not expect everybody is online and has time 24/7 - people are away from computers sometimes.
Thanks for input. Sorry, It will never happen again.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
hi guys, here is a very initial demo of PMA-Designer using jQueryUI API's. Suggestions are always welcome. drag and drop the fields and experience it. http://jollyhits.com/pma/ -- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
Le 2012-04-19 03:23, Adnan a écrit :
hi guys,
here is a very initial demo of PMA-Designer using jQueryUI API's. Suggestions are always welcome. drag and drop the fields and experience it. http://jollyhits.com/pma/
Hi, First, please use the correct terminology: tables and _columns_, not fields. Second, it's not intuitive that dragging a column to another table means to establish a relation between these tables. On the other hand, drawing a line between columns would be intuitive. -- Marc Delisle http://infomarc.info
On Thu, Apr 19, 2012 at 3:01 PM, Marc Delisle <marc@infomarc.info> wrote:
Le 2012-04-19 03:23, Adnan a écrit :
hi guys,
here is a very initial demo of PMA-Designer using jQueryUI API's. Suggestions are always welcome. drag and drop the fields and experience it. http://jollyhits.com/pma/
Hi,
First, please use the correct terminology: tables and _columns_, not fields.
Ok
Second, it's not intuitive that dragging a column to another table means to establish a relation between these tables.
On the other hand, drawing a line between columns would be intuitive.
Of course, There would be a line showing relation between columns using
Canvas tags like in current PMA-Designer. I was showing a very initial demo with dragging columns actually.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Muhammad Adnan Twitter: @hiddenpearls I blog too do u know ? http:// www.imblog.info Failure takes you higher than success ..! you sell code, I sell my brain.
Quoting Marc Delisle <marc@infomarc.info>:
Le 2012-04-19 03:23, Adnan a écrit :
hi guys,
here is a very initial demo of PMA-Designer using jQueryUI API's. Suggestions are always welcome. drag and drop the fields and experience it. http://jollyhits.com/pma/
Hi,
First, please use the correct terminology: tables and _columns_, not fields.
Second, it's not intuitive that dragging a column to another table means to establish a relation between these tables.
On the other hand, drawing a line between columns would be intuitive.
Also, positioning a table behind another table sometimes triggers the "Confirm relation" message. Bye, Rouslan
participants (5)
-
Adnan -
Dieter Adriaenssens -
Marc Delisle -
Michal Čihař -
Rouslan Placella