3 Aug
2012
3 Aug
'12
12:28 p.m.
Hi all,
Quick question: why do we have two forms for renaming a table on
tbl_operations.php? Can one be dropped? Please see attached screenshot
for the location of forms.
Bye,
Rouslan
3 Aug
3 Aug
2:36 p.m.
Hi
Dne Fri, 03 Aug 2012 11:28:31 +0200
Rouslan Placella <rouslan(a)placella.com> napsal(a):
Quick question: why do we have two forms for renaming
a table on
tbl_operations.php? Can one be dropped? Please see attached screenshot
for the location of forms.
The difference is probably in implementation - in same database, you
can use just RENAME, for moving data to other database, this might
fail, so basically it's CREATE TABLE and INSERT .. SELECT.
Still it would be better to merge these and use RENAME when possible
and fallback to complex method if needed.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
3:19 p.m.
Michal Čihař a écrit :
Hi
Dne Fri, 03 Aug 2012 11:28:31 +0200
Rouslan Placella <rouslan(a)placella.com> napsal(a):
I'm not sure these should be merged. In the mind of some users, renaming
and moving are different actions.
--
Marc Delisle
http://infomarc.info
Quick question: why do we have two forms for
renaming a table on
tbl_operations.php? Can one be dropped? Please see attached screenshot
for the location of forms.
The difference is probably in implementation - in same database, you
can use just RENAME, for moving data to other database, this might
fail, so basically it's CREATE TABLE and INSERT .. SELECT.
Still it would be better to merge these and use RENAME when possible
and fallback to complex method if needed.
6:19 p.m.
On 03/08/2012 14:19, Marc Delisle wrote:
Then we could call it "rename/move"...
Michal Čihař a écrit :
> Hi
>
> Dne Fri, 03 Aug 2012 11:28:31 +0200
> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>
>> Quick question: why do we have two forms for renaming a table on
>> tbl_operations.php? Can one be dropped? Please see attached screenshot
>> for the location of forms.
Well, I have a dilemma about this form in my branch. With the "rename"
functionality in the table options form, a dedicated ajax handler is
necessary for it to work. Without, the form can be handled by a generic
page loading mechanism, which means less code and a more maintainable
solution.
> The difference is probably in implementation - in
same database, you
> can use just RENAME, for moving data to other database, this might
> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
I see, it sounds a bit more complicated than I was hoping for.
Still it would
be better to merge these and use RENAME when possible
and fallback to complex method if needed.
I'm not sure these should be merged. In the mind of some users, renaming
and moving are different actions.
6:41 p.m.
Rouslan Placella a écrit :
On 03/08/2012 14:19, Marc Delisle wrote:
Then we could call it "rename/move"...
I would be happy with that. It would have the added benefit of removing
the rename table dialog from the table options fieldset, where it does
not really belong.
--
Marc Delisle
http://infomarc.info
Michal Čihař a écrit :
> Hi
>
> Dne Fri, 03 Aug 2012 11:28:31 +0200
> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>
>> Quick question: why do we have two forms for renaming a table on
>> tbl_operations.php? Can one be dropped? Please see attached screenshot
>> for the location of forms.
Well, I have a dilemma about this form in my branch. With the "rename"
functionality in the table options form, a dedicated ajax handler is
necessary for it to work. Without, the form can be handled by a generic
page loading mechanism, which means less code and a more maintainable
solution.
> The difference is probably in implementation
- in same database, you
> can use just RENAME, for moving data to other database, this might
> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
I see, it sounds a bit more complicated than I was hoping for.
Still it
would be better to merge these and use RENAME when possible
and fallback to complex method if needed.
I'm not sure these should be merged.
In the mind of some users, renaming
and moving are different actions.
6:43 p.m.
Marc Delisle a écrit :
Rouslan Placella a écrit :
By the way, Thilina is refactoring db and tbl operations these days...
--
Marc Delisle
http://infomarc.info
On 03/08/2012 14:19, Marc Delisle wrote:
Then we could call it "rename/move"...
I would be happy with that. It would have the added benefit of removing
the rename table dialog from the table options fieldset, where it does
not really belong.
Michal Čihař a écrit :
> Hi
>
> Dne Fri, 03 Aug 2012 11:28:31 +0200
> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>
>> Quick question: why do we have two forms for renaming a table on
>> tbl_operations.php? Can one be dropped? Please see attached screenshot
>> for the location of forms.
Well, I have a dilemma about this form in my
branch. With the "rename"
functionality in the table options form, a dedicated ajax handler is
necessary for it to work. Without, the form can be handled by a generic
page loading mechanism, which means less code and a more maintainable
solution.
> The difference is probably in implementation
- in same database, you
> can use just RENAME, for moving data to other database, this might
> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
I see, it
sounds a bit more complicated than I was hoping for.
Still it
would be better to merge these and use RENAME when possible
and fallback to complex method if needed.
I'm not sure these should be merged.
In the mind of some users, renaming
and moving are different actions.
6:45 p.m.
On 03/08/2012 17:43, Marc Delisle wrote:
Marc Delisle a écrit :
Sounds like one of us will have a few conflicts to resolve. I already
have some committed changes in those areas. When does he expect to
finish up with that?
Rouslan Placella a écrit :
By the way, Thilina is refactoring db and tbl operations these days... On 03/08/2012 14:19, Marc Delisle wrote:
I would be happy with that. It would have the added benefit of removing
the rename table dialog from the table options fieldset, where it does
not really belong.
Michal Čihař a écrit :
> Hi
>
> Dne Fri, 03 Aug 2012 11:28:31 +0200
> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>
>> Quick question: why do we have two forms for renaming a table on
>> tbl_operations.php? Can one be dropped? Please see attached screenshot
>> for the location of forms.
Well, I have a dilemma about this form in my
branch. With the "rename"
functionality in the table options form, a dedicated ajax handler is
necessary for it to work. Without, the form can be handled by a generic
page loading mechanism, which means less code and a more maintainable
solution.
> The difference is probably in implementation
- in same database, you
> can use just RENAME, for moving data to other database, this might
> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
I see, it
sounds a bit more complicated than I was hoping for.
> Still it would be better to merge these and
use RENAME when possible
> and fallback to complex method if needed.
I'm not sure these should be merged. In the mind of some users, renaming
and moving are different actions.
Then we could call it "rename/move"...
7:54 p.m.
On 03/08/2012 17:45, Rouslan Placella wrote:
On 03/08/2012 17:43, Marc Delisle wrote:
Or did you mean asking Thilina to look into this?
Marc Delisle a écrit :
Sounds like one of us will have a few conflicts to resolve. I already
have some committed changes in those areas. When does he expect to
finish up with that? Rouslan Placella a écrit :
By the way, Thilina is refactoring db and tbl operations these days... On 03/08/2012 14:19, Marc Delisle wrote:
> Michal Čihař a écrit :
>> Hi
>>
>> Dne Fri, 03 Aug 2012 11:28:31 +0200
>> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>>
>>> Quick question: why do we have two forms for renaming a table on
>>> tbl_operations.php? Can one be dropped? Please see attached screenshot
>>> for the location of forms.
Well, I have a dilemma about this form in my branch. With the "rename"
functionality in the table options form, a dedicated ajax handler is
necessary for it to work. Without, the form can be handled by a generic
page loading mechanism, which means less code and a more maintainable
solution.
>> The difference is probably in implementation - in same database, you
>> can use just RENAME, for moving data to other database, this might
>> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
I see, it sounds a bit more complicated than I was hoping for.
>> Still it would be better to merge these and use RENAME when possible
>> and fallback to complex method if needed.
> I'm not sure these should be merged. In the mind of some users, renaming
> and moving are different actions.
Then we could call it "rename/move"...
I would be happy with that. It would have the added benefit of removing
the rename table dialog from the table options fieldset, where it does
not really belong.
8:48 p.m.
New subject: [Phpmyadmin-devel] ***SPAM*** Re: Duplicate forms
Rouslan Placella a écrit :
On 03/08/2012 17:45, Rouslan Placella wrote:
I only meant that you two guys should talk to each other, especially if
you already have changes in your tree about the operations stuff.
It's up to him if he wants to merge these two dialogs; it was not
planned in his schedule.
--
Marc Delisle
http://infomarc.info
On 03/08/2012 17:43, Marc Delisle wrote:
Or did you mean asking Thilina to look into this? Marc Delisle a écrit :
Sounds like one of us will have a few conflicts to resolve. I already
have some committed changes in those areas. When does he expect to
finish up with that? Rouslan Placella a écrit :
> On 03/08/2012 14:19, Marc Delisle wrote:
>> Michal Čihař a écrit :
>>> Hi
>>>
>>> Dne Fri, 03 Aug 2012 11:28:31 +0200
>>> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>>>
>>>> Quick question: why do we have two forms for renaming a table on
>>>> tbl_operations.php? Can one be dropped? Please see attached screenshot
>>>> for the location of forms.
> Well, I have a dilemma about this form in my branch. With the "rename"
> functionality in the table options form, a dedicated ajax handler is
> necessary for it to work. Without, the form can be handled by a generic
> page loading mechanism, which means less code and a more maintainable
> solution.
>
>>> The difference is probably in implementation - in same database, you
>>> can use just RENAME, for moving data to other database, this might
>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
> I see, it sounds a bit more complicated than I was hoping for.
>
>>> Still it would be better to merge these and use RENAME when possible
>>> and fallback to complex method if needed.
>> I'm not sure these should be merged. In the mind of some users, renaming
>> and moving are different actions.
> Then we could call it "rename/move"...
I would be happy with that. It would have the added benefit of removing
the rename table dialog from the table options fieldset, where it does
not really belong.
By the way, Thilina is refactoring db and tbl operations these days...
4 Aug
4 Aug
11:48 a.m.
New subject: [Phpmyadmin-devel] ***SPAM*** Re: Duplicate forms
On 03/08/2012 19:48, Marc Delisle wrote:
Rouslan Placella a écrit :
Fair enough, as he said that he already did refactoring work on these
forms, I think that I'll just write a dedicated ajax handler for them as
to avoid further merge conflicts. I'll look into this issue once again
after all the merges, when the table operations code will ve stable.
On 03/08/2012 17:45, Rouslan Placella wrote:
I only meant that you two guys should talk to each other, especially if
you already have changes in your tree about the operations stuff.
It's up to him if he wants to merge these two dialogs; it was not
planned in his schedule. On 03/08/2012 17:43, Marc Delisle wrote:
Or did you mean asking Thilina to look into this? Marc Delisle a écrit :
> Rouslan Placella a écrit :
>> On 03/08/2012 14:19, Marc Delisle wrote:
>>> Michal Čihař a écrit :
>>>> Hi
>>>>
>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200
>>>> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>>>>
>>>>> Quick question: why do we have two forms for renaming a table on
>>>>> tbl_operations.php? Can one be dropped? Please see attached
screenshot
>>>>> for the location of forms.
>> Well, I have a dilemma about this form in my branch. With the "rename"
>> functionality in the table options form, a dedicated ajax handler is
>> necessary for it to work. Without, the form can be handled by a generic
>> page loading mechanism, which means less code and a more maintainable
>> solution.
>>
>>>> The difference is probably in implementation - in same database, you
>>>> can use just RENAME, for moving data to other database, this might
>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
>> I see, it sounds a bit more complicated than I was hoping for.
>>
>>>> Still it would be better to merge these and use RENAME when possible
>>>> and fallback to complex method if needed.
>>> I'm not sure these should be merged. In the mind of some users, renaming
>>> and moving are different actions.
>> Then we could call it "rename/move"...
> I would be happy with that. It would have the added benefit of removing
> the rename table dialog from the table options fieldset, where it does
> not really belong.
>
By the way, Thilina is refactoring db and tbl operations these days...
Sounds like
one of us will have a few conflicts to resolve. I already
have some committed changes in those areas. When does he expect to
finish up with that? 
2:39 a.m.
On Fri, Aug 3, 2012 at 10:24 PM, Rouslan Placella <rouslan(a)placella.com>wrote;wrote:
On 03/08/2012 17:45, Rouslan Placella wrote:
Sounds like one of us will have a few conflicts to resolve. I already
have some committed changes in those areas. When does he expect to
finish up with that?
Or did you mean asking Thilina to look into this?
Hi,
For the moment, I have done some refactoring for both rename table and move
table operations in my tree,
--
Regards.
Thilina Abeyrathna
Gtalk : thilinaabeyrathna
skype: thilinabuddika88
thilinaa.wordpress.com
On 03/08/2012 17:43, Marc Delisle wrote:
> Marc Delisle a écrit :
>> Rouslan Placella a écrit :
>>> On 03/08/2012 14:19, Marc Delisle wrote:
>>>> Michal Čihař a écrit :
>>>>> Hi
>>>>>
>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200
>>>>> Rouslan Placella <rouslan(a)placella.com> napsal(a):
>>>>>
>>>>>> Quick question: why do we have two forms for renaming a table on
>>>>>> tbl_operations.php? Can one be dropped? Please see attached
screenshot
>>>>>> for the location of
forms.
>>> Well, I have a dilemma about this form in my branch. With the
"rename"
>>> functionality in the table options form, a dedicated ajax handler is
>>> necessary for it to work. Without, the form can be handled by a
generic
>>> page loading mechanism, which means
less code and a more maintainable
>>> solution.
>>>
>>>>> The difference is probably in implementation - in same database, you
>>>>> can use just RENAME, for moving data to other database, this might
>>>>> fail, so basically it's CREATE TABLE and INSERT .. SELECT.
>>> I see, it sounds a bit more complicated than I was hoping for.
>>>
>>>>> Still it would be better to merge these and use RENAME when possible
>>>>> and fallback to complex method if needed.
>>>> I'm not sure these should be merged. In the mind of some users,
renaming
>> and moving are different actions.
> Then we could call it "rename/move"...
I would be happy with that. It would have the added benefit of removing
the rename table dialog from the table options fieldset, where it does
not really belong.
By the way, Thilina is refactoring db and tbl operations these days...
12:30 p.m.
On 04/08/2012 01:39, Thilina Buddika Abeyrathna wrote:
On Fri, Aug 3, 2012 at 10:24 PM, Rouslan Placella <rouslan(a)placella.com
<mailto:rouslan@placella.com>> wrote:
On 03/08/2012 17:45, Rouslan Placella wrote:
Which repo/branch/commits? I don't see anything like that in
https://github.com/thilinaa/phpmyadmin/commits/master
Bye,
Rouslan
On 03/08/2012 17:43, Marc Delisle wrote:
> Marc Delisle a écrit :
>> Rouslan Placella a écrit :
>>> On 03/08/2012 14:19, Marc Delisle wrote:
>>>> Michal Čihař a écrit :
>>>>> Hi
>>>>>
>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200
>>>>> Rouslan Placella <rouslan(a)placella.com
<mailto:rouslan@placella.com>> napsal(a):
>>>>>
>>>>>> Quick question: why do we have two forms for renaming a
table on
>>>>>> tbl_operations.php? Can
one be dropped? Please see attached
screenshot
>>>>>> for the location of
forms.
>>> Well, I have a dilemma about this form in my branch. With the
"rename"
>>> functionality in the table options
form, a dedicated ajax
handler is
>>> necessary for it to work. Without,
the form can be handled by
a generic
>>> page loading mechanism, which means
less code and a more
maintainable
>>> solution.
>>>
>>>>> The difference is probably in implementation - in same
database, you
>>>>> can use just RENAME, for
moving data to other database, this
might
>>>>> fail, so basically it's
CREATE TABLE and INSERT .. SELECT.
>>> I see, it sounds a bit more complicated than I was hoping for.
>>>
>>>>> Still it would be better to merge these and use RENAME when
possible
>>>>> and fallback to complex
method if needed.
>>>> I'm not sure these should be merged. In the mind of some
users, renaming
>>>> and moving are different
actions.
>>> Then we could call it "rename/move"...
>>
>> I would be happy with that. It would have the added benefit of
removing
>> the rename table dialog from the table
options fieldset, where
it does
>> not really belong.
>>
> By the way, Thilina is refactoring db and tbl operations these
days...
Sounds like one of us will have a few conflicts to resolve. I already
have some committed changes in those areas. When does he expect to
finish up with that?
Or did you mean asking Thilina to look into this?
Hi,
For the moment, I have done some refactoring for both rename table and
move table operations in my tree,
6:04 p.m.
On Sat, Aug 4, 2012 at 3:00 PM, Rouslan Placella <rouslan(a)placella.com>wrote;wrote:
On 04/08/2012 01:39, Thilina Buddika Abeyrathna
wrote:
Which repo/branch/commits? I don't see anything like that in
https://github.com/thilinaa/phpmyadmin/commits/master
Some commits,
[1] -
https://github.com/thilinaa/phpmyadmin/commit/d9933223977c52426edcfc9f558fc…
[2] -
https://github.com/thilinaa/phpmyadmin/commit/83401195710de736dc6217f885313…
But some functions has changed for further refactoring.
--
Regards.
Thilina Abeyrathna
Gtalk : thilinaabeyrathna
skype: thilinabuddika88
thilinaa.wordpress.com
On Fri, Aug 3, 2012 at 10:24 PM, Rouslan Placella <rouslan(a)placella.com
<mailto:rouslan@placella.com>> wrote:
On 03/08/2012 17:45, Rouslan Placella wrote:
already
On 03/08/2012 17:43, Marc Delisle wrote:
> Marc Delisle a écrit :
>> Rouslan Placella a écrit :
>>> On 03/08/2012 14:19, Marc Delisle wrote:
>>>> Michal Čihař a écrit :
>>>>> Hi
>>>>>
>>>>> Dne Fri, 03 Aug 2012 11:28:31 +0200
>>>>> Rouslan Placella <rouslan(a)placella.com
<mailto:rouslan@placella.com>> napsal(a):
>>>>>
>>>>>> Quick question: why do we have two forms for renaming a
table on
>>>>>> tbl_operations.php? Can
one be dropped? Please see attached
screenshot
>>>>>> for the location of
forms.
>>> Well, I have a dilemma about this form in my branch. With the
"rename"
>>> functionality in the table options
form, a dedicated ajax
handler is
>>> necessary for it to work. Without,
the form can be handled by
a generic
>>> page loading mechanism, which means
less code and a more
maintainable
>>> solution.
>>>
>>>>> The difference is probably in implementation - in same
database, you
>>>>> can use just RENAME, for
moving data to other database, this
might
>>>>> fail, so basically it's
CREATE TABLE and INSERT .. SELECT.
>>> I see, it sounds a bit more complicated than I was hoping for.
>>>
>>>>> Still it would be better to merge these and use RENAME when
possible
>>>>> and fallback to complex
method if needed.
>>>> I'm not sure these should be merged. In the mind of some
users, renaming
>>>> and moving are different
actions.
>>> Then we could call it "rename/move"...
>>
>> I would be happy with that. It would have the added benefit of
removing
>> the rename table dialog from the table
options fieldset, where
it does
>> not really belong.
>>
> By the way, Thilina is refactoring db and tbl operations these
days...
>
> Sounds like one of us will have a few conflicts to resolve. I have some
committed changes in those areas. When does he expect to
finish up with that?
Or did you mean asking Thilina to look into this?
Hi,
For the moment, I have done some refactoring for both rename table and
move table operations in my tree,
4426
days inactive
4427
days old
12 comments
4 participants
participants (4)
-
Marc Delisle -
Michal Čihař -
Rouslan Placella -
Thilina Buddika Abeyrathna