16 Jan
2015
16 Jan
'15
8:48 a.m.
Hi,
I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works
fine for me.
Even if this is a new parser, the code won't affect anything but the new
Format option so I am in favor of merging it.
--
Marc Delisle | phpMyAdmin
16 Jan
16 Jan
10:21 a.m.
On Fri, Jan 16, 2015 at 4:18 PM, Marc Delisle <marc(a)infomarc.info> wrote:
Hi,
I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works
fine for me.
Even if this is a new parser, the code won't affect anything but the new
Format option so I am in favor of merging it.
I am also in favor.
Either the GSoC project on parser or an improved version of
CodeMirror
formatter may override this in the future. But for now, since this works
just fine, I think it makes sense to merge it.
--
Thanks and Regards,
Madhura Jayaratne
10:26 a.m.
On 16-Jan-2015 5:15 pm, "Marc Delisle" <marc(a)infomarc.info> wrote:
Hi,
I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works
fine for me.
Even if this is a new parser, the code won't affect anything but the new
Format option so I am in favor of merging it.
I would like to test this on HHVM once. I will do that soon.
--
Marc Delisle | phpMyAdmin
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center
in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
12:51 p.m.
On Fri, Jan 16, 2015 at 5:56 PM, Chirayu Chiripal <
chirayu.chiripal(a)gmail.com> wrote:
--
Regards,
Chirayu Chiripal
https://chirayuchiripal.wordpress.com/
On 16-Jan-2015 5:15 pm, "Marc Delisle" <marc(a)infomarc.info> wrote:
Works fine on HHVM.
Hi,
I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works
fine for me.
Even if this is a new parser, the code won't affect anything but the new
Format option so I am in favor of merging it.
I would like to test this on HHVM once. I will do that soon.
--
Marc Delisle | phpMyAdmin
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data
Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
12:17 p.m.
Hi
Dne Fri, 16 Jan 2015 05:48:49 -0500
Marc Delisle <marc(a)infomarc.info> napsal(a):
Hi,
I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works
fine for me.
Even if this is a new parser, the code won't affect anything but the new
Format option so I am in favor of merging it.
Can it have some testsuite before merging please?
--
Michal Čihař | http://cihar.com | http://phpmyadmin.net
12:55 p.m.
On Fri, Jan 16, 2015 at 7:47 PM, Michal Čihař <michal(a)cihar.com> wrote:
Hi
Dne Fri, 16 Jan 2015 05:48:49 -0500
Marc Delisle <marc(a)infomarc.info> napsal(a):
The maintainer has some tests (I have not checked coverage or anything
else). It might help https://github.com/jdorn/sql-formatter
Hi,
I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works
fine for me.
Even if this is a new parser, the code won't affect anything but the new
Format option so I am in favor of merging it.
Can it have some testsuite before merging please?
--
Michal Čihař | http://cihar.com | http://phpmyadmin.net
--
Nisarg Jhaveri
નિસર્ગ ઝવેરી
2:36 p.m.
On 16 Jan 2015 17:15, "Marc Delisle" <marc(a)infomarc.info> wrote:
Hi,
I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works
fine for me.
Even if this is a new parser, the code won't affect anything but the new
Format option so I am in favor of merging it.
I am also in favor of merging it!
--
Regards
Atul Pratap Singh
3522
days inactive
3522
days old
6 comments
6 participants
participants (6)
-
Atul Pratap Singh -
Chirayu Chiripal -
Madhura Jayaratne -
Marc Delisle -
Michal Čihař -
Nisarg Jhaveri