Hi, I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works fine for me.
Even if this is a new parser, the code won't affect anything but the new Format option so I am in favor of merging it.
On Fri, Jan 16, 2015 at 4:18 PM, Marc Delisle marc@infomarc.info wrote:
Hi, I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works fine for me.
Even if this is a new parser, the code won't affect anything but the new Format option so I am in favor of merging it.
I am also in favor.
Either the GSoC project on parser or an improved version of CodeMirror formatter may override this in the future. But for now, since this works just fine, I think it makes sense to merge it.
On 16-Jan-2015 5:15 pm, "Marc Delisle" marc@infomarc.info wrote:
Hi, I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works fine for me.
Even if this is a new parser, the code won't affect anything but the new Format option so I am in favor of merging it.
I would like to test this on HHVM once. I will do that soon.
-- Marc Delisle | phpMyAdmin
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Fri, Jan 16, 2015 at 5:56 PM, Chirayu Chiripal < chirayu.chiripal@gmail.com> wrote:
On 16-Jan-2015 5:15 pm, "Marc Delisle" marc@infomarc.info wrote:
Hi, I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works fine for me.
Even if this is a new parser, the code won't affect anything but the new Format option so I am in favor of merging it.
I would like to test this on HHVM once. I will do that soon.
Works fine on HHVM.
-- Marc Delisle | phpMyAdmin
New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi
Dne Fri, 16 Jan 2015 05:48:49 -0500 Marc Delisle marc@infomarc.info napsal(a):
Hi, I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works fine for me.
Even if this is a new parser, the code won't affect anything but the new Format option so I am in favor of merging it.
Can it have some testsuite before merging please?
On Fri, Jan 16, 2015 at 7:47 PM, Michal Čihař michal@cihar.com wrote:
Hi
Dne Fri, 16 Jan 2015 05:48:49 -0500 Marc Delisle marc@infomarc.info napsal(a):
Hi, I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works fine for me.
Even if this is a new parser, the code won't affect anything but the new Format option so I am in favor of merging it.
Can it have some testsuite before merging please?
The maintainer has some tests (I have not checked coverage or anything else). It might help https://github.com/jdorn/sql-formatter
-- Michal Čihař | http://cihar.com | http://phpmyadmin.net
On 16 Jan 2015 17:15, "Marc Delisle" marc@infomarc.info wrote:
Hi, I tried https://github.com/phpmyadmin/phpmyadmin/pull/1450 and it works fine for me.
Even if this is a new parser, the code won't affect anything but the new Format option so I am in favor of merging it.
I am also in favor of merging it!
-- Regards
Atul Pratap Singh
-
Atul Pratap Singh -
Chirayu Chiripal -
Madhura Jayaratne -
Marc Delisle -
Michal Čihař -
Nisarg Jhaveri