Sebastian Mendel a écrit :

Marc Delisle schrieb:

...

Hi,

The latest commit to common.lib.php does not respect PEAR standards, IMO. Too much white space.

Have a look at how they recommend to format "if":

if ($arg1 == 'good' || $arg1 == 'fair') { $this->foo = $arg1; return 1; } elseif ($arg1 == 'poor' && $arg2 > 1) { $this->foo = 'poor'; return 2; } else { return false; }

http://pear.php.net/manual/en/standards.sample.php

mhm ... grr ..

i really dont like how PEAR coding standard handles whitespaces

... i find it looks much better and is in most cases more readable with whitespaces ... but i do as our documentation saith! ;-)

:)

Note that at least for me, it's not clear what they recommend for things like the "not" operator in

if ( ! PMA_auth_check() ) {

since they recommend a space before and after operators like "||".

Marc