Hi,
Please comment on this patch which fixes (at least on my server) the problem of going from the main PMA script to scripts/setup.php and back. I noticed that "source" was empty when I have this problem.
Patch is against MAINT_2_8_2.
Index: common.lib.php =================================================================== RCS file: /cvsroot/phpmyadmin/phpMyAdmin/libraries/common.lib.php,v retrieving revision 2.266.2.27.2.2 diff -c -r2.266.2.27.2.2 common.lib.php *** common.lib.php 21 Aug 2006 11:45:16 -0000 2.266.2.27.2.2 --- common.lib.php 21 Aug 2006 17:28:19 -0000 *************** *** 2991,2997 ****
/******************************************************************************/ /* parsing config file LABEL_parsing_config_file */
! if (empty($_SESSION['PMA_Config'])) { /** * We really need this one! */ --- 2991,2998 ----
/******************************************************************************/ /* parsing config file LABEL_parsing_config_file */
! //if (empty($_SESSION['PMA_Config'])) { ! if (empty($_SESSION['PMA_Config']) || empty($_SESSION['PMA_Config']->source )) { /** * We really need this one! */
Hi
On Mon, 21 Aug 2006 13:31:41 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Please comment on this patch which fixes (at least on my server) the problem of going from the main PMA script to scripts/setup.php and back. I noticed that "source" was empty when I have this problem.
The real problem is probably in mixing local variable PMA_Config from setup with session one. Do you have enabled register_globals?
Anyway if this is a problem, cleaner solution would be to rename PMA_Config variable in setup.php to something different, can you try it?
Michal Čihař a écrit :
Hi
On Mon, 21 Aug 2006 13:31:41 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Please comment on this patch which fixes (at least on my server) the problem of going from the main PMA script to scripts/setup.php and back. I noticed that "source" was empty when I have this problem.
The real problem is probably in mixing local variable PMA_Config from setup with session one. Do you have enabled register_globals?
Anyway if this is a problem, cleaner solution would be to rename PMA_Config variable in setup.php to something different, can you try it?
I confirm that this bug only happens with register_globals = On ! This explains why it could not be reproduced on your server.
And your cleaner solution works, I'll merge it instead of mine and release 2.8.2.3 with this and the IIS fix.
Thanks
Marc