On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir ammaryasir.88@gmail.comwrote:
On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir ammaryasir.88@gmail.comwrote:
On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir ayax88@gmail.com wrote:
On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle marc@infomarc.infowrote:
Le 2011-07-11 21:26, Ammar Yasir a écrit :
On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Le 2011-07-09 22:59, Ammar Yasir a écrit : > > > I've done a basic version of edit functionality. I added aunique
> identifier for each row in the query result data by using the > PMA_getUniqueCondition() from the common.lib.php file (where_clause). I > then generate the update query in the edit submit event using this where > clause and post it to sql.php. The return data is added to the > <sqlqueryresult> div to show the query executed and themessage. The
> plot also updates on submit if one of the axes is updated. Ismy
logic > is okay? > I've pushed my work and you can try scenarios on the film_actor table in > the sakila database. Ammar, I tried with the film table, changing the "title" column and got this error: value is undefined at line 177 in js/tbl_zoom_plot.js.Fixed some issues and pushed it to my repo. Had to add checkboxes for null condition on fields (in Data point content section).
It works fine now. Please don't forget the issue of generating the default data label based on the "display field".
Fixed this, default label is taken from table display field. Also changed the type of xAxis to linear (t defaulted to timeline earlier).
There was a small thing I noticed on the row edit feature. When the form is displayed for row edit and some field is null, the 'Null' checkbox is checked. When we select some value it is unchecked. It should be checked again if we select the value empty or null but it does not. If we forget to check it back this will give an SQL error. Screenshot attached for the sakila db film table where original_language_id is null, and if I miss checking it back I'll get an SQL error.
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
Yes, working on it now.
-- Marc Delisle http://infomarc.info
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-14 15:39, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir ammaryasir.88@gmail.comwrote:
On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir ammaryasir.88@gmail.comwrote:
On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir ayax88@gmail.com wrote:
On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle marc@infomarc.infowrote:
Le 2011-07-11 21:26, Ammar Yasir a écrit :
On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Le 2011-07-09 22:59, Ammar Yasir a écrit : > > > I've done a basic version of edit functionality. I added aunique
> identifier for each row in the query result data by using the > PMA_getUniqueCondition() from the common.lib.php file (where_clause). I > then generate the update query in the edit submit event using this where > clause and post it to sql.php. The return data is added to the > <sqlqueryresult> div to show the query executed and themessage. The
> plot also updates on submit if one of the axes is updated. Ismy
logic > is okay? > I've pushed my work and you can try scenarios on the film_actor table in > the sakila database. Ammar, I tried with the film table, changing the "title" column and got this error: value is undefined at line 177 in js/tbl_zoom_plot.js.Fixed some issues and pushed it to my repo. Had to add checkboxes for null condition on fields (in Data point content section).
It works fine now. Please don't forget the issue of generating the default data label based on the "display field".
Fixed this, default label is taken from table display field.
It still does not work. When I initially enter Zoom search, $zoom_submit and $inputs are not defined so $dataLabel does not receive the results of PMA_getDisplayField($db,$table).
Also changed the type of xAxis to linear (t defaulted to timeline earlier).
There was a small thing I noticed on the row edit feature. When the form is displayed for row edit and some field is null, the 'Null' checkbox is checked. When we select some value it is unchecked. It should be checked again if we select the value empty or null but it does not. If we forget to check it back this will give an SQL error. Screenshot attached for the sakila db film table where original_language_id is null, and if I miss checking it back I'll get an SQL error.
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
On Fri, Jul 15, 2011 at 7:19 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir <ammaryasir.88@gmail.com wrote:
On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir <ammaryasir.88@gmail.com
wrote:
On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir ayax88@gmail.com wrote:
On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle <marc@infomarc.info
wrote:
Le 2011-07-11 21:26, Ammar Yasir a écrit : > > > On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc@infomarc.info > mailto:marc@infomarc.info> wrote: > > Le 2011-07-09 22:59, Ammar Yasir a écrit : > > > > > > I've done a basic version of edit functionality. I added a unique > > identifier for each row in the query result data by using the > > PMA_getUniqueCondition() from the common.lib.php file > (where_clause). I > > then generate the update query in the edit submit event using > this where > > clause and post it to sql.php. The return data is added to
the
> > <sqlqueryresult> div to show the query executed and the message. The > > plot also updates on submit if one of the axes is updated. Is my > logic > > is okay? > > I've pushed my work and you can try scenarios on the
film_actor
> table in > > the sakila database. > > Ammar, > I tried with the film table, changing the "title" column and got > this error: > value is undefined at line 177 in js/tbl_zoom_plot.js. > > Fixed some issues and pushed it to my repo. Had to add checkboxes
for
> null condition on fields (in Data point content section).
It works fine now. Please don't forget the issue of generating the default data label
based
on the "display field".
Fixed this, default label is taken from table display field.
It still does not work. When I initially enter Zoom search, $zoom_submit and $inputs are not defined so $dataLabel does not receive the results of PMA_getDisplayField($db,$table).
I think I misunderstood. What I am doing is that, if a user does not
selects a datalabel, it defaults to the display field. That works fine. I guess what you are saying is that the default selected value/index should be the display field?
Also changed the type of xAxis to linear (t defaulted to timeline earlier).
There was a small thing I noticed on the row edit feature. When the form is displayed for row edit and some field is null, the
'Null'
checkbox is checked. When we select some value it is unchecked. It
should be
checked again if we select the value empty or null but it does not. If
we
forget to check it back this will give an SQL error. Screenshot attached for the sakila db film table where original_language_id is null, and if I miss checking it back I'll get
an SQL
error.
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
-- Marc Delisle http://infomarc.info
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-15 09:56, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:19 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir <ammaryasir.88@gmail.com wrote:
On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir <ammaryasir.88@gmail.com
wrote:
On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir ayax88@gmail.com wrote:
On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle <marc@infomarc.info
wrote:
> Le 2011-07-11 21:26, Ammar Yasir a écrit : >> >> >> On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc@infomarc.info >> mailto:marc@infomarc.info> wrote: >> >> Le 2011-07-09 22:59, Ammar Yasir a écrit : >> > >> > >> > I've done a basic version of edit functionality. I added a > unique >> > identifier for each row in the query result data by using the >> > PMA_getUniqueCondition() from the common.lib.php file >> (where_clause). I >> > then generate the update query in the edit submit event using >> this where >> > clause and post it to sql.php. The return data is added to
the
>> > <sqlqueryresult> div to show the query executed and the > message. The >> > plot also updates on submit if one of the axes is updated. Is > my >> logic >> > is okay? >> > I've pushed my work and you can try scenarios on the
film_actor
>> table in >> > the sakila database. >> >> Ammar, >> I tried with the film table, changing the "title" column and got >> this error: >> value is undefined at line 177 in js/tbl_zoom_plot.js. >> >> Fixed some issues and pushed it to my repo. Had to add checkboxes
for
>> null condition on fields (in Data point content section). > > It works fine now. > Please don't forget the issue of generating the default data label
based
> on the "display field". >
Fixed this, default label is taken from table display field.
It still does not work. When I initially enter Zoom search, $zoom_submit and $inputs are not defined so $dataLabel does not receive the results of PMA_getDisplayField($db,$table).
I think I misunderstood. What I am doing is that, if a user does not
selects a datalabel, it defaults to the display field. That works fine. I guess what you are saying is that the default selected value/index should be the display field?
When a user enters zoom-search, it would be very reassuring to see that the default label is set to the display column (from PMA_getDisplayField()). Otherwise, the user who has already set this display column in Relation view will wonder what's going on.
On Fri, Jul 15, 2011 at 7:30 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-15 09:56, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:19 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 1:01 AM, Ammar Yasir <ammaryasir.88@gmail.com wrote:
On Fri, Jul 15, 2011 at 12:59 AM, Ammar Yasir <
ammaryasir.88@gmail.com
wrote:
On Wed, Jul 13, 2011 at 3:24 AM, Ammar Yasir ayax88@gmail.com
wrote:
> > > On Tue, Jul 12, 2011 at 6:32 PM, Marc Delisle <marc@infomarc.info
wrote:
> >> Le 2011-07-11 21:26, Ammar Yasir a écrit : >>> >>> >>> On Mon, Jul 11, 2011 at 3:16 AM, Marc Delisle <marc@infomarc.info >>> mailto:marc@infomarc.info> wrote: >>> >>> Le 2011-07-09 22:59, Ammar Yasir a écrit : >>> > >>> > >>> > I've done a basic version of edit functionality. I added a >> unique >>> > identifier for each row in the query result data by using
the
>>> > PMA_getUniqueCondition() from the common.lib.php file >>> (where_clause). I >>> > then generate the update query in the edit submit event
using
>>> this where >>> > clause and post it to sql.php. The return data is added to
the
>>> > <sqlqueryresult> div to show the query executed and the >> message. The >>> > plot also updates on submit if one of the axes is updated.
Is
>> my >>> logic >>> > is okay? >>> > I've pushed my work and you can try scenarios on the
film_actor
>>> table in >>> > the sakila database. >>> >>> Ammar, >>> I tried with the film table, changing the "title" column and
got
>>> this error: >>> value is undefined at line 177 in js/tbl_zoom_plot.js. >>> >>> Fixed some issues and pushed it to my repo. Had to add checkboxes
for
>>> null condition on fields (in Data point content section). >> >> It works fine now. >> Please don't forget the issue of generating the default data label
based
>> on the "display field". >> > Fixed this, default label is taken from table display field.
It still does not work. When I initially enter Zoom search, $zoom_submit and $inputs are not defined so $dataLabel does not receive the results of PMA_getDisplayField($db,$table).
I think I misunderstood. What I am doing is that, if a user does not
selects a datalabel, it defaults to the display field. That works fine. I guess what you are saying is that the default selected value/index should
be
the display field?
When a user enters zoom-search, it would be very reassuring to see that the default label is set to the display column (from PMA_getDisplayField()). Otherwise, the user who has already set this display column in Relation view will wonder what's going on.
Yes true. Made the changes and pushed to my repo.
-- Marc Delisle http://infomarc.info
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-15 10:08, Ammar Yasir a écrit :
When a user enters zoom-search, it would be very reassuring to see that the default label is set to the display column (from PMA_getDisplayField()). Otherwise, the user who has already set this display column in Relation view will wonder what's going on.
Yes true. Made the changes and pushed to my repo.
Now it works initially but there is another bug: if I change it to another column, it is reset to the display column after the following click.
In my setup, the display column is title. It correctly appears initially as the data label but if I change the data label to description, it comes back to title after form submission.
Le 2011-07-14 15:39, Ammar Yasir a écrit :
There was a small thing I noticed on the row edit feature. When the form is displayed for row edit and some field is null, the 'Null' checkbox is checked. When we select some value it is unchecked. It should be checked again if we select the value empty or null but it does not. If we forget to check it back this will give an SQL error. Screenshot attached for the sakila db film table where original_language_id is null, and if I miss checking it back I'll get an SQL error.
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
I think you'll need to include js/tbl_change.js. There are a few functions in there that deal with these kind of verifications. Beware, some functions are not jQueryfied.
On Fri, Jul 15, 2011 at 7:26 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
There was a small thing I noticed on the row edit feature. When the form is displayed for row edit and some field is null, the
'Null'
checkbox is checked. When we select some value it is unchecked. It
should be
checked again if we select the value empty or null but it does not. If
we
forget to check it back this will give an SQL error. Screenshot attached for the sakila db film table where original_language_id is null, and if I miss checking it back I'll get
an SQL
error.
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
I think you'll need to include js/tbl_change.js. There are a few functions in there that deal with these kind of verifications. Beware, some functions are not jQueryfied.
I found this problem in the tbl_change.php (when you edit a row from the
table browse window) page. That includes the tbl_change.js script.
-- Marc Delisle http://infomarc.info
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-15 10:00, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:26 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
There was a small thing I noticed on the row edit feature. When the form is displayed for row edit and some field is null, the
'Null'
checkbox is checked. When we select some value it is unchecked. It
should be
checked again if we select the value empty or null but it does not. If
we
forget to check it back this will give an SQL error. Screenshot attached for the sakila db film table where original_language_id is null, and if I miss checking it back I'll get
an SQL
error.
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
I think you'll need to include js/tbl_change.js. There are a few functions in there that deal with these kind of verifications. Beware, some functions are not jQueryfied.
I found this problem in the tbl_change.php (when you edit a row from the
table browse window) page. That includes the tbl_change.js script.
I believed you meant when editing from zoom-search, sorry. But I tried with browse then editing the sakila.film and I don't see a problem.
Emptying a value is not the same thing as marking it NULL, this is why the checkbox is there. Please give me a more precise scenario to work with, including the SQL error you get.
On Fri, Jul 15, 2011 at 7:40 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-15 10:00, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:26 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
There was a small thing I noticed on the row edit feature. When the form is displayed for row edit and some field is null, the
'Null'
checkbox is checked. When we select some value it is unchecked. It
should be
checked again if we select the value empty or null but it does not.
If
we
forget to check it back this will give an SQL error. Screenshot attached for the sakila db film table where original_language_id is null, and if I miss checking it back I'll get
an SQL
error.
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
I think you'll need to include js/tbl_change.js. There are a few functions in there that deal with these kind of verifications. Beware, some functions are not jQueryfied.
I found this problem in the tbl_change.php (when you edit a row from the
table browse window) page. That includes the tbl_change.js script.
I believed you meant when editing from zoom-search, sorry. But I tried with browse then editing the sakila.film and I don't see a problem.
Emptying a value is not the same thing as marking it NULL, this is why the checkbox is there. Please give me a more precise scenario to work with, including the SQL error you get.
If i try the film table in sakila database, and edit any row. The
original_language_id is null initally and if I select andy value the check is unchecked. Then again if I select ' ' in the select box, I though it should turn the check back on, just in case if I forget it gives an error.
The screen shots are on my blog http://ammaryasirr.blogspot.com/
-- Marc Delisle http://infomarc.info
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-15 10:15, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:40 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-15 10:00, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:26 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
> There was a small thing I noticed on the row edit feature. > When the form is displayed for row edit and some field is null, the
'Null'
> checkbox is checked. When we select some value it is unchecked. It
should be
> checked again if we select the value empty or null but it does not.
If
we
> forget to check it back this will give an SQL error. > Screenshot attached for the sakila db film table where > original_language_id is null, and if I miss checking it back I'll get
an SQL
> error. >
Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
I think you'll need to include js/tbl_change.js. There are a few functions in there that deal with these kind of verifications. Beware, some functions are not jQueryfied.
I found this problem in the tbl_change.php (when you edit a row from the
table browse window) page. That includes the tbl_change.js script.
I believed you meant when editing from zoom-search, sorry. But I tried with browse then editing the sakila.film and I don't see a problem.
Emptying a value is not the same thing as marking it NULL, this is why the checkbox is there. Please give me a more precise scenario to work with, including the SQL error you get.
If i try the film table in sakila database, and edit any row. The
original_language_id is null initally and if I select andy value the check is unchecked. Then again if I select ' ' in the select box, I though it should turn the check back on, just in case if I forget it gives an error.
The screen shots are on my blog http://ammaryasirr.blogspot.com/
Ok I had played to much with my version of sakila and was missing some relations. I recreated it.
The real problem is that the list of values should not contain a blank value. Now I'm wondering in which situation we need this blank line! This comes from libraries/relation.lib.php in PMA_foreignDropdown().
Checking NULL automatically is not something phpMyAdmin can decide to do. However we know we can uncheck it when a value has been entered.
On Fri, Jul 15, 2011 at 8:04 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-15 10:15, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:40 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2011-07-15 10:00, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:26 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
>> There was a small thing I noticed on the row edit feature. >> When the form is displayed for row edit and some field is null, the
'Null'
>> checkbox is checked. When we select some value it is unchecked. It
should be
>> checked again if we select the value empty or null but it does not.
If
we
>> forget to check it back this will give an SQL error. >> Screenshot attached for the sakila db film table where >> original_language_id is null, and if I miss checking it back I'll
get
an SQL
>> error. >> > Sorry, missed the screenshots in previous mail. They are on my blog: http://ammaryasirr.blogspot.com/
I think you'll need to include js/tbl_change.js. There are a few functions in there that deal with these kind of verifications. Beware, some functions are not jQueryfied.
I found this problem in the tbl_change.php (when you edit a row from
the
table browse window) page. That includes the tbl_change.js script.
I believed you meant when editing from zoom-search, sorry. But I tried with browse then editing the sakila.film and I don't see a problem.
Emptying a value is not the same thing as marking it NULL, this is why the checkbox is there. Please give me a more precise scenario to work with, including the SQL error you get.
If i try the film table in sakila database, and edit any row. The
original_language_id is null initally and if I select andy value the
check
is unchecked. Then again if I select ' ' in the select box, I though it should turn the check back on, just in case if I forget it gives an
error.
The screen shots are on my blog http://ammaryasirr.blogspot.com/
Ok I had played to much with my version of sakila and was missing some relations. I recreated it.
The real problem is that the list of values should not contain a blank value. Now I'm wondering in which situation we need this blank line! This comes from libraries/relation.lib.php in PMA_foreignDropdown().
Checking NULL automatically is not something phpMyAdmin can decide to do. However we know we can uncheck it when a value has been entered.
The blank line comes from $ret = '<option value=""> </option>'; (in
function PMA_foerignDropDown() in raltions.lib.php) . If you see the language_id field above the original_language_id, it also has a 'blank' option. If that is selected then also it gives SQL error. So I dont know why we should have 'blank' as an option. The foreign key on one table will be primary key of some other. Hence, never 'blank' .
-- Marc Delisle http://infomarc.info
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-15 10:54, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 8:04 PM, Marc Delisle marc@infomarc.info wrote:
Le 2011-07-15 10:15, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:40 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2011-07-15 10:00, Ammar Yasir a écrit :
On Fri, Jul 15, 2011 at 7:26 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2011-07-14 15:39, Ammar Yasir a écrit :
>>> There was a small thing I noticed on the row edit feature. >>> When the form is displayed for row edit and some field is null, the 'Null' >>> checkbox is checked. When we select some value it is unchecked. It should be >>> checked again if we select the value empty or null but it does not.
If
we >>> forget to check it back this will give an SQL error. >>> Screenshot attached for the sakila db film table where >>> original_language_id is null, and if I miss checking it back I'll
get
an SQL >>> error. >>> >> > Sorry, missed the screenshots in previous mail. They are on my blog: > http://ammaryasirr.blogspot.com/
I think you'll need to include js/tbl_change.js. There are a few functions in there that deal with these kind of verifications. Beware, some functions are not jQueryfied.
I found this problem in the tbl_change.php (when you edit a row from
the
table browse window) page. That includes the tbl_change.js script.
I believed you meant when editing from zoom-search, sorry. But I tried with browse then editing the sakila.film and I don't see a problem.
Emptying a value is not the same thing as marking it NULL, this is why the checkbox is there. Please give me a more precise scenario to work with, including the SQL error you get.
If i try the film table in sakila database, and edit any row. The
original_language_id is null initally and if I select andy value the
check
is unchecked. Then again if I select ' ' in the select box, I though it should turn the check back on, just in case if I forget it gives an
error.
The screen shots are on my blog http://ammaryasirr.blogspot.com/
Ok I had played to much with my version of sakila and was missing some relations. I recreated it.
The real problem is that the list of values should not contain a blank value. Now I'm wondering in which situation we need this blank line! This comes from libraries/relation.lib.php in PMA_foreignDropdown().
Checking NULL automatically is not something phpMyAdmin can decide to do. However we know we can uncheck it when a value has been entered.
The blank line comes from $ret = '<option value=""> </option>'; (in
function PMA_foerignDropDown() in raltions.lib.php) . If you see the language_id field above the original_language_id, it also has a 'blank' option. If that is selected then also it gives SQL error. So I dont know why we should have 'blank' as an option. The foreign key on one table will be primary key of some other. Hence, never 'blank' .
Blank is a good option when user is inserting a row, as we don't know yet which value the user will want. And it's better not to force one of the values.
We probably need a new parameter to indicate whether we are editing or inserting. Feel free to open a bug artifact about this.
-
Ammar Yasir -
Marc Delisle