[Phpmyadmin-devel] Reminder: ChangeLog is UTF-8

Hi Robin :-) the ChangeLog is in UTF-8, please don't break it with every commit, thanks -- Michal Čihař | http://cihar.com

On Mon, Jul 11, 2005 at 11:40:34AM +0200, Michal ??iha?? wrote:
the ChangeLog is in UTF-8, please don't break it with every commit, thanks Just wondering, but what editor are you using?
I'm using vim-6.3.075, with fileencoding=utf-8, so it should be perfectly fine. If I open, write, close the ChangeLog from a known good state, it makes these changes: --- ChangeLog.good 2005-07-11 10:58:32.000000000 -0700 +++ ChangeLog 2005-07-11 10:58:56.000000000 -0700 @@ -9,7 +9,7 @@ * tbl_relations.php: bug #1227710, unsaved relations lost when changing field to display -2005-07-11 Michal �iha� <michal@cihar.com> +2005-07-11 Michal � �iha� � <michal@cihar.com> * db_operations.php: Allow adding DROP TABLE when copying database (RFE #1235761). @@ -19,7 +19,7 @@ Document previous foreign-key dropdown work, and also ensure that the configuration import code works properly with it. -2005-07-10 Michal �iha� <michal@cihar.com> +2005-07-10 Michal � �iha� � <michal@cihar.com> * libraries/auth/http.auth.lib.php: Support FastGCI in http auth (patch #1192219) * Documentation.html, config.inc.php, left.php, queryframe.php, @@ -68,13 +68,13 @@ instructions, thanks to Isaac Bennetch - ibennetch 2005-06-30 Marc Delisle <lem9@users.sourceforge.net> - * lang/hungarian update, thanks to Mihály Mészáros <necronix@freemail.hu> + * lang/hungarian update, thanks to Mih�¡ly M�©sz�¡ros <necronix@freemail.hu> * lang/japanese: updated, thanks to Tadashi Jokagi (elf2000) * lang/chinese_traditional: Updates, thanks to Siu Sun * lang/catalan update, thanks to Xavier Navarro (xavin). * lang/lithuanian: Updated, thanks to Vilius Simonaitis - maumas98 * lang/danish: Updated, thanks to AlleyKat - dk_alleykat. - * lang/swedish: Updated, thanks to Björn T. Hallberg (bth). + * lang/swedish: Updated, thanks to Bj�¶rn T. Hallberg (bth). 2005-06-29 Marc Delisle <lem9@users.sourceforge.net> * tbl_properties_table_info.php: bug #1228862, creating a table under [lots more of it here] -- Robin Hugh Johnson E-Mail : robbat2@orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85

Robin, You can call changelog.php from your browser to see the ChangeLog and check if special characters are still OK after your edit session. Marc Robin H. Johnson a écrit :
On Mon, Jul 11, 2005 at 11:40:34AM +0200, Michal ??iha?? wrote:
the ChangeLog is in UTF-8, please don't break it with every commit, thanks
Just wondering, but what editor are you using?
I'm using vim-6.3.075, with fileencoding=utf-8, so it should be perfectly fine.
If I open, write, close the ChangeLog from a known good state, it makes these changes:
--- ChangeLog.good 2005-07-11 10:58:32.000000000 -0700 +++ ChangeLog 2005-07-11 10:58:56.000000000 -0700 @@ -9,7 +9,7 @@ * tbl_relations.php: bug #1227710, unsaved relations lost when changing field to display
-2005-07-11 Michal �iha� <michal@cihar.com> +2005-07-11 Michal � �iha� � <michal@cihar.com> * db_operations.php: Allow adding DROP TABLE when copying database (RFE #1235761).
@@ -19,7 +19,7 @@ Document previous foreign-key dropdown work, and also ensure that the configuration import code works properly with it.
-2005-07-10 Michal �iha� <michal@cihar.com> +2005-07-10 Michal � �iha� � <michal@cihar.com> * libraries/auth/http.auth.lib.php: Support FastGCI in http auth (patch #1192219) * Documentation.html, config.inc.php, left.php, queryframe.php, @@ -68,13 +68,13 @@ instructions, thanks to Isaac Bennetch - ibennetch
2005-06-30 Marc Delisle <lem9@users.sourceforge.net> - * lang/hungarian update, thanks to Mihály Mészáros <necronix@freemail.hu> + * lang/hungarian update, thanks to Mih�¡ly M�©sz�¡ros <necronix@freemail.hu> * lang/japanese: updated, thanks to Tadashi Jokagi (elf2000) * lang/chinese_traditional: Updates, thanks to Siu Sun * lang/catalan update, thanks to Xavier Navarro (xavin). * lang/lithuanian: Updated, thanks to Vilius Simonaitis - maumas98 * lang/danish: Updated, thanks to AlleyKat - dk_alleykat. - * lang/swedish: Updated, thanks to Björn T. Hallberg (bth). + * lang/swedish: Updated, thanks to Bj�¶rn T. Hallberg (bth).
2005-06-29 Marc Delisle <lem9@users.sourceforge.net> * tbl_properties_table_info.php: bug #1228862, creating a table under [lots more of it here]

On Monday 11 July 2005 20:23, Marc Delisle wrote:
You can call changelog.php from your browser to see the ChangeLog and check if special characters are still OK after your edit session.
I thing it's easier to call cvs diff and see how much the file has been changed :-) -- Michal Čihař | http://cihar.com

On Monday 11 July 2005 20:16, Robin H. Johnson wrote:
On Mon, Jul 11, 2005 at 11:40:34AM +0200, Michal ??iha?? wrote:
the ChangeLog is in UTF-8, please don't break it with every commit, thanks
Just wondering, but what editor are you using?
$ editor --version VIM - Vi IMproved 6.3 (2004 June 7, compiled Jun 15 2005 18:30:13) Included patches: 1-78 [...]
I'm using vim-6.3.075, with fileencoding=utf-8, so it should be perfectly fine.
Don't you have some functions that modify buffer/settings while saving? -- Michal Čihař | http://cihar.com

On Mon, Jul 11, 2005 at 08:23:29PM +0200, Michal ??iha?? wrote:
On Monday 11 July 2005 20:16, Robin H. Johnson wrote:
On Mon, Jul 11, 2005 at 11:40:34AM +0200, Michal ??iha?? wrote:
the ChangeLog is in UTF-8, please don't break it with every commit, thanks
Just wondering, but what editor are you using?
$ editor --version VIM - Vi IMproved 6.3 (2004 June 7, compiled Jun 15 2005 18:30:13) Included patches: 1-78 [...] To be more exact:
VIM - Vi IMproved 6.3 (2004 June 7, compiled May 30 2005 15:29:56) Included patches: 1-67, 69-74 Compiled by portage@x29 Huge version without GUI. Features included (+) or not (-): +arabic +autocmd -balloon_eval -browse ++builtin_terms +byte_offset +cindent -clientserver -clipboard +cmdline_compl +cmdline_hist +cmdline_info +comments +cryptv +cscope +dialog_con +diff +digraphs -dnd -ebcdic +emacs_tags +eval +ex_extra +extra_search +farsi +file_in_path +find_in_path +folding -footer +fork() +gettext -hangul_input +iconv +insert_expand +jumplist +keymap +langmap +libcall +linebreak +lispindent +listcmds +localmap +menu +mksession +modify_fname +mouse -mouseshape +mouse_dec +mouse_gpm -mouse_jsbterm +mouse_netterm +mouse_xterm +multi_byte +multi_lang -netbeans_intg -osfiletype +path_extra +perl +postscript +printer +python +quickfix +rightleft -ruby +scrollbind +signs +smartindent -sniff +statusline -sun_workshop +syntax +tag_binary +tag_old_static -tag_any_white -tcl +terminfo +termresponse +textobjects +title -toolbar +user_commands +vertsplit +virtualedit +visual +visualextra +viminfo +vreplace +wildignore +wildmenu +windows +writebackup -X11 -xfontset -xim -xsmp -xterm_clipboard -xterm_save
I'm using vim-6.3.075, with fileencoding=utf-8, so it should be perfectly fine. Don't you have some functions that modify buffer/settings while saving? Nope, nothing beyond modelines.
-- Robin Hugh Johnson E-Mail : robbat2@orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85

On Mon 11. 7. 2005 20:40, Robin H. Johnson wrote:
On Mon, Jul 11, 2005 at 08:23:29PM +0200, Michal ??iha?? wrote:
On Monday 11 July 2005 20:16, Robin H. Johnson wrote:
I'm using vim-6.3.075, with fileencoding=utf-8, so it should be perfectly fine.
Don't you have some functions that modify buffer/settings while saving?
Nope, nothing beyond modelines.
And what encoding do you use? (encoding is the one used internally by vim) -- Michal Čihař | http://cihar.com

On Tue, Jul 12, 2005 at 12:26:43AM +0200, Michal ??iha?? wrote:
Nope, nothing beyond modelines. And what encoding do you use? (encoding is the one used internally by vim) Ah, that's solved it.
I added set encoding=utf-8 to my global vimrc, and now it doesn't screw stuff up anymore. Thanks. -- Robin Hugh Johnson E-Mail : robbat2@orbis-terrarum.net Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
participants (3)
-
Marc Delisle
-
Michal Čihař
-
Robin H. Johnson