[Phpmyadmin-devel] Horizontal scrollbars in master (from lorilee branch)

Hi, Master branch shows horizontal scrollbars (FF 3.6, FF4, Opera 10.6) which should never appear, it's caused by the addition of width: 100%; height: 100%; block in theme_right.css.php from lorilee branch. Lori, is there a particular reason for these values or can they be safely removed? -- Piotr Przybylski

Hi Piotr, Sorry for the delay in response, I was on holiday since Friday. I am not 100% certain at the moment but I think it's because the ENUM/SET editor popup did not display properly in IE without it. I can't verify this at the moment but I can do so tomorrow and try to find a workaround. On Fri, Aug 27, 2010 at 6:18 AM, Piotr Przybylski <piotr.prz@gmail.com>wrote:
Hi,
Master branch shows horizontal scrollbars (FF 3.6, FF4, Opera 10.6) which should never appear, it's caused by the addition of width: 100%; height: 100%; block in theme_right.css.php from lorilee branch.
Lori, is there a particular reason for these values or can they be safely removed?
-- Piotr Przybylski
------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thanks, Lori

2010/8/31 Lori Lee <leelorik@gmail.com>:
On Fri, Aug 27, 2010 at 6:18 AM, Piotr Przybylski <piotr.prz@gmail.com> wrote:
Hi,
Master branch shows horizontal scrollbars (FF 3.6, FF4, Opera 10.6) which should never appear, it's caused by the addition of width: 100%; height: 100%; block in theme_right.css.php from lorilee branch.
Lori, is there a particular reason for these values or can they be safely removed?
Hi Piotr,
Sorry for the delay in response, I was on holiday since Friday. I am not 100% certain at the moment but I think it's because the ENUM/SET editor popup did not display properly in IE without it. I can't verify this at the moment but I can do so tomorrow and try to find a workaround.
The problem is that final element width is calculated like this: width (100%) + left and right margin + left and right padding, resulting in a value over 100%. Which version of IE did you have problems with? If it's IE6, maybe we can just drop support for it? It's still some time until new code is released so it will be even less popular then. -- Piotr Przybylski

Hi Piotr, I just checked, it only happens in IE6. The form is still fairly usable, the only thing that happens is that the black overlay that covers the screen behind the popup only shows up as a 50-pixel-tall bar at the top of the screen. On Tue, Aug 31, 2010 at 2:52 AM, Piotr Przybylski <piotr.prz@gmail.com>wrote:
2010/8/31 Lori Lee <leelorik@gmail.com>:
On Fri, Aug 27, 2010 at 6:18 AM, Piotr Przybylski <piotr.prz@gmail.com> wrote:
Hi,
Master branch shows horizontal scrollbars (FF 3.6, FF4, Opera 10.6) which should never appear, it's caused by the addition of width: 100%; height: 100%; block in theme_right.css.php from lorilee branch.
Lori, is there a particular reason for these values or can they be safely removed?
Hi Piotr,
Sorry for the delay in response, I was on holiday since Friday. I am not 100% certain at the moment but I think it's because the ENUM/SET editor popup did not display properly in IE without it. I can't verify this at the moment but I can do so tomorrow and try to find a workaround.
The problem is that final element width is calculated like this: width (100%) + left and right margin + left and right padding, resulting in a value over 100%. Which version of IE did you have problems with? If it's IE6, maybe we can just drop support for it? It's still some time until new code is released so it will be even less popular then.
-- Piotr Przybylski
------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thanks, Lori

2010/8/31 Lori Lee <leelorik@gmail.com>:
On Tue, Aug 31, 2010 at 2:52 AM, Piotr Przybylski <piotr.prz@gmail.com> wrote:
2010/8/31 Lori Lee <leelorik@gmail.com>:
On Fri, Aug 27, 2010 at 6:18 AM, Piotr Przybylski <piotr.prz@gmail.com> wrote:
Hi,
Master branch shows horizontal scrollbars (FF 3.6, FF4, Opera 10.6) which should never appear, it's caused by the addition of width: 100%; height: 100%; block in theme_right.css.php from lorilee branch.
Lori, is there a particular reason for these values or can they be safely removed?
Hi Piotr,
Sorry for the delay in response, I was on holiday since Friday. I am not 100% certain at the moment but I think it's because the ENUM/SET editor popup did not display properly in IE without it. I can't verify this at the moment but I can do so tomorrow and try to find a workaround.
The problem is that final element width is calculated like this: width (100%) + left and right margin + left and right padding, resulting in a value over 100%. Which version of IE did you have problems with? If it's IE6, maybe we can just drop support for it? It's still some time until new code is released so it will be even less popular then.
Hi Piotr,
I just checked, it only happens in IE6. The form is still fairly usable, the only thing that happens is that the black overlay that covers the screen behind the popup only shows up as a 50-pixel-tall bar at the top of the screen.
Ok, then if nobody objects, I will remove these two properties (100% width and height on body). -- Piotr Przybylski
participants (2)
-
Lori Lee
-
Piotr Przybylski